diff options
| author | Robert Godfrey <rgodfrey@apache.org> | 2010-09-17 14:56:47 +0000 |
|---|---|---|
| committer | Robert Godfrey <rgodfrey@apache.org> | 2010-09-17 14:56:47 +0000 |
| commit | f54cd2b5bacb97e89d0582a3f7b2348d7bdb9494 (patch) | |
| tree | 08bd4511c89cd0b5a6f3227dbe181fd32073074f /qpid/java/management/agent/src | |
| parent | 0137301436e2c8ad42bd4c04ef6ff76484391aa2 (diff) | |
| download | qpid-python-f54cd2b5bacb97e89d0582a3f7b2348d7bdb9494.tar.gz | |
QPID-2857 : Address issues found by running FindBugs against the Java codebase
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@998162 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'qpid/java/management/agent/src')
3 files changed, 3 insertions, 5 deletions
diff --git a/qpid/java/management/agent/src/main/java/org/apache/qpid/agent/Agent.java b/qpid/java/management/agent/src/main/java/org/apache/qpid/agent/Agent.java index f6ae6adbc3..b1a4a8c93e 100644 --- a/qpid/java/management/agent/src/main/java/org/apache/qpid/agent/Agent.java +++ b/qpid/java/management/agent/src/main/java/org/apache/qpid/agent/Agent.java @@ -79,7 +79,7 @@ public class Agent implements MessageListener protected Map<Long, ManagedObject> objects = new Hashtable<Long, ManagedObject>(); protected long bbank; protected long abank; - protected static Log log = LogFactory.getLog(Agent.class); + protected static final Log log = LogFactory.getLog(Agent.class); protected volatile boolean inside = false; protected ClassLoader classLoader = null; @@ -491,7 +491,6 @@ public class Agent implements MessageListener try { byte[] buf = new byte[1024]; - byte[] body = new byte[1024]; BytesMessage msg = session.createBytesMessage(); ByteBuffer slice = enc.segment(); while (slice.hasRemaining()) diff --git a/qpid/java/management/agent/src/main/java/org/apache/qpid/agent/binding/BindingContext.java b/qpid/java/management/agent/src/main/java/org/apache/qpid/agent/binding/BindingContext.java index 835fed0ce1..a60178e8b9 100644 --- a/qpid/java/management/agent/src/main/java/org/apache/qpid/agent/binding/BindingContext.java +++ b/qpid/java/management/agent/src/main/java/org/apache/qpid/agent/binding/BindingContext.java @@ -57,7 +57,7 @@ public class BindingContext @Override public boolean equals(Object obj) { - return ((obj.getClass() == Key.class) + return (obj instanceof Key && (((Key) obj).packageName.equals(packageName)) && (((Key) obj).className .equals(className))); } diff --git a/qpid/java/management/agent/src/main/java/org/apache/qpid/agent/binding/ClassBinding.java b/qpid/java/management/agent/src/main/java/org/apache/qpid/agent/binding/ClassBinding.java index 0a74958023..469939a52f 100644 --- a/qpid/java/management/agent/src/main/java/org/apache/qpid/agent/binding/ClassBinding.java +++ b/qpid/java/management/agent/src/main/java/org/apache/qpid/agent/binding/ClassBinding.java @@ -42,7 +42,7 @@ import org.apache.qpid.transport.codec.Encoder; */ public class ClassBinding implements TypeBinding { - private static Log log = LogFactory.getLog(ClassBinding.class); + private static final Log log = LogFactory.getLog(ClassBinding.class); private static enum MethodType { @@ -131,7 +131,6 @@ public class ClassBinding implements TypeBinding } // Look at the superclass, if it is also a // QMF object then stop. - Class superType = cls.getSuperclass(); if (!this.hasQMFSupertype(cls)) { for (Method m : this.getMethods(cls.getSuperclass())) |