QPID-2731: enable the jmx management console to set boolean attribute values

git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@964824 13f79535-47bb-0310-9956-ffa450edef68

2 files changed, 13 insertions, 1 deletions

diff --git a/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/jmx/MBeanUtility.java b/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/jmx/MBeanUtility.java
index 2f5752db9b..855b2e2a1e 100644
--- a/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/jmx/MBeanUtility.java
+++ b/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/jmx/MBeanUtility.java
@@ -426,6 +426,15 @@ public class MBeanUtility
             }
             newValue = new Integer(Integer.parseInt(value));
         }
+        else if (attribute.getDataType().equals(Boolean.class.getName()))
+        {
+            if (!value.equalsIgnoreCase("true") && !value.equalsIgnoreCase("false"))
+            {
+                throw new ManagementConsoleException("Entered value was not true or false");
+            }
+
+            newValue = new Boolean(Boolean.valueOf(value)); 
+        }
         
         mbsc.setAttribute(jmxbean.getObjectName(), new Attribute(attribute.getName(), newValue));           
         // Update the value in the registry, to avoid refreshing from mbsc
diff --git a/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/AttributesTabControl.java b/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/AttributesTabControl.java
index f21647b2d2..01f81b9d34 100644
--- a/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/AttributesTabControl.java
+++ b/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/AttributesTabControl.java
@@ -502,7 +502,10 @@ public class AttributesTabControl extends TabControl
                 if (attribute.isWritable())
                 {
                     value = _toolkit.createText(parent, "", SWT.BEGINNING | SWT.BORDER);
-                    value.addVerifyListener(new NumberVerifyListener());
+                    if(attribute.isNumber())
+                    {
+                        value.addVerifyListener(new NumberVerifyListener());
+                    }
                     
                     // set data to access in the listener
                     parent.setData(attribute);