diff options
| author | Robert Godfrey <rgodfrey@apache.org> | 2010-09-12 22:40:40 +0000 |
|---|---|---|
| committer | Robert Godfrey <rgodfrey@apache.org> | 2010-09-12 22:40:40 +0000 |
| commit | 8c8130d0288446f88deef393823cccffcaed474d (patch) | |
| tree | 781c5801bc2e3d2f84724bec6c959b2af329f3bd /qpid/java/management/tools | |
| parent | 8a4c51f79be29149fa30a01e7fab6f36301f24bb (diff) | |
| download | qpid-python-8c8130d0288446f88deef393823cccffcaed474d.tar.gz | |
QPID-2857 : Address issues found by running FindBugs against the Java codebase
git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@996393 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'qpid/java/management/tools')
5 files changed, 5 insertions, 9 deletions
diff --git a/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/ReportGenerator.java b/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/ReportGenerator.java index cc8c16f8b0..9d14f78b42 100644 --- a/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/ReportGenerator.java +++ b/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/ReportGenerator.java @@ -48,7 +48,7 @@ public class ReportGenerator implements Runnable generatereport(); try { - Thread.sleep(this.interval * 60000); + Thread.sleep((long)this.interval * 60000L); } catch (Exception ex) { diff --git a/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/commands/Commandget.java b/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/commands/Commandget.java index 8d690ac7f7..cb67edeb34 100644 --- a/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/commands/Commandget.java +++ b/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/commands/Commandget.java @@ -34,7 +34,7 @@ public class Commandget extends CommandImpl private String _attributeName; private String _value; - public static String COMMAND_NAME = "get"; + public static final String COMMAND_NAME = "get"; public Commandget(JMXinfo info) { diff --git a/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/commands/Commandset.java b/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/commands/Commandset.java index b5cc9e6090..e70b7b17ad 100644 --- a/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/commands/Commandset.java +++ b/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/commands/Commandset.java @@ -34,7 +34,7 @@ public class Commandset extends CommandImpl { private String _attributeName; private String _value; - public static String COMMAND_NAME = "set"; + public static final String COMMAND_NAME = "set"; public Commandset(JMXinfo info) { diff --git a/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/commands/Commandview.java b/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/commands/Commandview.java index e98cb336d8..e3bcc7e543 100644 --- a/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/commands/Commandview.java +++ b/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/commands/Commandview.java @@ -58,10 +58,8 @@ public class Commandview extends CommandImpl public void viewmessages() { - Set set = null; - Object temp[] = { null }; objname.setQueryString(this.getObject(), this.getName(), this.getVirtualhost()); - set = objname.returnObjects(); + Set set = objname.returnObjects(); String header = "", temp_header = "", message_data = "", outline = ""; if (objname.getSet().size() != 0) diff --git a/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/commands/Commandviewcontent.java b/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/commands/Commandviewcontent.java index 0c8a4b62b4..d1ae1c1893 100644 --- a/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/commands/Commandviewcontent.java +++ b/qpid/java/management/tools/qpid-cli/src/org/apache/qpid/commands/Commandviewcontent.java @@ -56,10 +56,8 @@ public class Commandviewcontent extends CommandImpl public void viewcontent() { - Set set = null; - Object temp[] = { null }; objname.setQueryString(getObject(), getName(), getVirtualhost()); - set = objname.returnObjects(); + Set set = objname.returnObjects(); String temp_header = "", header = "", message_data = "", encoding = null; if (objname.getSet().size() != 0) |