summaryrefslogtreecommitdiff
path: root/qpid/java
diff options
context:
space:
mode:
authororudyy <orudyy@unknown>2015-04-02 16:30:07 +0000
committerorudyy <orudyy@unknown>2015-04-02 16:30:07 +0000
commit4107358e3e6cd033195e6b7e95af6c4111feda88 (patch)
tree2ebbdbe879eddf4a6561ad107640069a63c59825 /qpid/java
parent6603e157e9c45772110468a722157e531db06a9f (diff)
downloadqpid-python-4107358e3e6cd033195e6b7e95af6c4111feda88.tar.gz
QPID-6469: Remove not used method sendResponseAndCloseSender from AMQProtocolEngine.
Remove exception handling code from ProtocolEngine_1_0_0_SASL as it is not used by new i/o layer git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1670933 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'qpid/java')
-rw-r--r--qpid/java/broker-plugins/amqp-0-8-protocol/src/main/java/org/apache/qpid/server/protocol/v0_8/AMQProtocolEngine.java29
-rw-r--r--qpid/java/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/ProtocolEngine_1_0_0_SASL.java38
2 files changed, 1 insertions, 66 deletions
diff --git a/qpid/java/broker-plugins/amqp-0-8-protocol/src/main/java/org/apache/qpid/server/protocol/v0_8/AMQProtocolEngine.java b/qpid/java/broker-plugins/amqp-0-8-protocol/src/main/java/org/apache/qpid/server/protocol/v0_8/AMQProtocolEngine.java
index 2178b4f6f3..f1e9f400f4 100644
--- a/qpid/java/broker-plugins/amqp-0-8-protocol/src/main/java/org/apache/qpid/server/protocol/v0_8/AMQProtocolEngine.java
+++ b/qpid/java/broker-plugins/amqp-0-8-protocol/src/main/java/org/apache/qpid/server/protocol/v0_8/AMQProtocolEngine.java
@@ -1161,35 +1161,6 @@ public class AMQProtocolEngine implements ServerProtocolEngine,
// noop - exception method is not used by new i/o layer
}
- private void sendResponseAndCloseSender(AMQDataBlock dataBlock)
- {
- try
- {
- writeFrame(dataBlock);
- }
- catch(SenderException e)
- {
- if (_logger.isDebugEnabled())
- {
- _logger.debug("Exception occurred on sending response", e);
- }
- }
- finally
- {
- try
- {
- _sender.close();
- }
- catch(SenderException e)
- {
- if (_logger.isDebugEnabled())
- {
- _logger.debug("Exception occurred on sender close", e);
- }
- }
- }
- }
-
public long getReadBytes()
{
return _readBytes;
diff --git a/qpid/java/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/ProtocolEngine_1_0_0_SASL.java b/qpid/java/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/ProtocolEngine_1_0_0_SASL.java
index 454c3e53cf..dc9564cc9f 100644
--- a/qpid/java/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/ProtocolEngine_1_0_0_SASL.java
+++ b/qpid/java/broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/ProtocolEngine_1_0_0_SASL.java
@@ -20,7 +20,6 @@
*/
package org.apache.qpid.server.protocol.v1_0;
-import java.io.IOException;
import java.io.PrintWriter;
import java.net.SocketAddress;
import java.nio.ByteBuffer;
@@ -51,8 +50,6 @@ import org.apache.qpid.amqp_1_0.transport.SaslServerProvider;
import org.apache.qpid.amqp_1_0.type.Binary;
import org.apache.qpid.amqp_1_0.type.FrameBody;
import org.apache.qpid.amqp_1_0.type.Symbol;
-import org.apache.qpid.amqp_1_0.type.transport.AmqpError;
-import org.apache.qpid.amqp_1_0.type.transport.Error;
import org.apache.qpid.common.QpidProperties;
import org.apache.qpid.common.ServerPropertyNames;
import org.apache.qpid.server.protocol.ServerProtocolEngine;
@@ -65,14 +62,11 @@ import org.apache.qpid.server.protocol.AMQSessionModel;
import org.apache.qpid.server.security.SubjectCreator;
import org.apache.qpid.server.security.auth.UsernamePrincipal;
import org.apache.qpid.server.util.Action;
-import org.apache.qpid.server.util.ServerScopedRuntimeException;
import org.apache.qpid.transport.ByteBufferSender;
-import org.apache.qpid.transport.TransportException;
import org.apache.qpid.transport.network.NetworkConnection;
public class ProtocolEngine_1_0_0_SASL implements ServerProtocolEngine, FrameOutputHandler
{
- private static final Logger _logger = LoggerFactory.getLogger(ProtocolEngine_1_0_0_SASL.class);
private final AmqpPort<?> _port;
private final Transport _transport;
@@ -449,37 +443,7 @@ public class ProtocolEngine_1_0_0_SASL implements ServerProtocolEngine, FrameOut
public void exception(Throwable throwable)
{
- if (throwable instanceof IOException)
- {
- _logger.info("IOException caught in " + this + ", connection closed implicitly: " + throwable);
- }
- else
- {
-
- try
- {
- final Error err = new Error();
- err.setCondition(AmqpError.INTERNAL_ERROR);
- err.setDescription(throwable.getMessage());
- _endpoint.close(err);
- close();
- }
- catch(TransportException e)
- {
- _logger.info("Error when handling exception",e);
- }
- finally
- {
- if(throwable instanceof java.lang.Error)
- {
- throw (java.lang.Error) throwable;
- }
- if(throwable instanceof ServerScopedRuntimeException)
- {
- throw (ServerScopedRuntimeException) throwable;
- }
- }
- }
+ // noop - exception method is not used by new i/o layer
}
public void closed()