summaryrefslogtreecommitdiff
path: root/java/broker/src
diff options
context:
space:
mode:
Diffstat (limited to 'java/broker/src')
-rw-r--r--java/broker/src/main/java/org/apache/qpid/server/plugins/Plugin.java10
-rw-r--r--java/broker/src/main/java/org/apache/qpid/server/security/AbstractPlugin.java23
2 files changed, 10 insertions, 23 deletions
diff --git a/java/broker/src/main/java/org/apache/qpid/server/plugins/Plugin.java b/java/broker/src/main/java/org/apache/qpid/server/plugins/Plugin.java
index 27bb050db4..e094422a1e 100644
--- a/java/broker/src/main/java/org/apache/qpid/server/plugins/Plugin.java
+++ b/java/broker/src/main/java/org/apache/qpid/server/plugins/Plugin.java
@@ -25,12 +25,10 @@ public interface Plugin
{
/**
- * Is this plugin configured?.
- */
- boolean isConfigured();
-
- /**
- * Configure this plugin
+ * Provide Configuration to this plugin
+ *
+ * FIXME Should not throw ConfigurationException,
+ * Only ConfigurationPlugin should throw ConfigurationException
*/
public void configure(ConfigurationPlugin config) throws ConfigurationException;
}
diff --git a/java/broker/src/main/java/org/apache/qpid/server/security/AbstractPlugin.java b/java/broker/src/main/java/org/apache/qpid/server/security/AbstractPlugin.java
index e0813b1fa7..87cc6e89aa 100644
--- a/java/broker/src/main/java/org/apache/qpid/server/security/AbstractPlugin.java
+++ b/java/broker/src/main/java/org/apache/qpid/server/security/AbstractPlugin.java
@@ -20,6 +20,7 @@
*/
package org.apache.qpid.server.security;
+import org.apache.commons.configuration.ConfigurationException;
import org.apache.log4j.Logger;
import org.apache.qpid.server.configuration.plugins.ConfigurationPlugin;
import org.apache.qpid.server.security.access.ObjectProperties;
@@ -33,7 +34,7 @@ public abstract class AbstractPlugin implements SecurityPlugin
{
protected final Logger _logger = Logger.getLogger(getClass());
- public ConfigurationPlugin _config;
+ protected ConfigurationPlugin _config;
public Result getDefault()
{
@@ -43,22 +44,10 @@ public abstract class AbstractPlugin implements SecurityPlugin
public abstract Result access(ObjectType object, Object instance);
public abstract Result authorise(Operation operation, ObjectType object, ObjectProperties properties);
-
- public boolean isConfigured()
- {
- if (_config == null)
- {
- return false;
- }
-
- for (String key : _config.getElementsProcessed())
- {
- if (!_config.getConfig().containsKey(key) && _config.getConfig().subset(key).isEmpty())
- {
- return false;
- }
- }
- return true;
+ public void configure(ConfigurationPlugin config) throws ConfigurationException
+ {
+ _config = config;
}
+
}