diff options
author | Adam Turner <9087854+AA-Turner@users.noreply.github.com> | 2022-10-15 23:01:25 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-10-15 23:01:25 +0100 |
commit | 10db540e9824a3747aa71947d0d4b039851172c3 (patch) | |
tree | 1b1591e06e0affed1f6b893c368a08626224bfaf | |
parent | 0fd45397c1d5a252dca4d2be793e5a1bf189a74a (diff) | |
download | sphinx-git-10db540e9824a3747aa71947d0d4b039851172c3.tar.gz |
Allow sections in object description directives (#10919)
-rw-r--r-- | CHANGES | 2 | ||||
-rw-r--r-- | sphinx/directives/__init__.py | 3 | ||||
-rw-r--r-- | tests/roots/test-object-description-sections/conf.py | 0 | ||||
-rw-r--r-- | tests/roots/test-object-description-sections/index.rst | 6 | ||||
-rw-r--r-- | tests/test_directive_object_description.py | 45 |
5 files changed, 55 insertions, 1 deletions
@@ -21,6 +21,8 @@ Features added Patch by Martin Liska. * #10881: autosectionlabel: Record the generated section label to the debug log. * #10268: Correctly URI-escape image filenames. +* #10887: domains: Allow sections in all the content of all object description + directives (e.g. :rst:dir:`py:function`). Patch by Adam Turner Bugs fixed ---------- diff --git a/sphinx/directives/__init__.py b/sphinx/directives/__init__.py index e59cb1295..8fcbd1fff 100644 --- a/sphinx/directives/__init__.py +++ b/sphinx/directives/__init__.py @@ -12,6 +12,7 @@ from sphinx.addnodes import desc_signature from sphinx.util import docutils from sphinx.util.docfields import DocFieldTransformer, Field, TypedField from sphinx.util.docutils import SphinxDirective +from sphinx.util.nodes import nested_parse_with_titles from sphinx.util.typing import OptionSpec if TYPE_CHECKING: @@ -259,7 +260,7 @@ class ObjectDescription(SphinxDirective, Generic[T]): # needed for association of version{added,changed} directives self.env.temp_data['object'] = self.names[0] self.before_content() - self.state.nested_parse(self.content, self.content_offset, contentnode) + nested_parse_with_titles(self.state, self.content, contentnode) self.transform_content(contentnode) self.env.app.emit('object-description-transform', self.domain, self.objtype, contentnode) diff --git a/tests/roots/test-object-description-sections/conf.py b/tests/roots/test-object-description-sections/conf.py new file mode 100644 index 000000000..e69de29bb --- /dev/null +++ b/tests/roots/test-object-description-sections/conf.py diff --git a/tests/roots/test-object-description-sections/index.rst b/tests/roots/test-object-description-sections/index.rst new file mode 100644 index 000000000..1892f94d6 --- /dev/null +++ b/tests/roots/test-object-description-sections/index.rst @@ -0,0 +1,6 @@ +.. py:function:: func() + + Overview + -------- + + Lorem ipsum dolar sit amet diff --git a/tests/test_directive_object_description.py b/tests/test_directive_object_description.py new file mode 100644 index 000000000..e161d5401 --- /dev/null +++ b/tests/test_directive_object_description.py @@ -0,0 +1,45 @@ +"""Test object description directives.""" + +import pytest +from docutils import nodes + +from sphinx import addnodes +from sphinx.io import create_publisher +from sphinx.util.docutils import sphinx_domains + + +def _doctree_for_test(builder, docname: str) -> nodes.document: + builder.env.prepare_settings(docname) + publisher = create_publisher(builder.app, 'restructuredtext') + with sphinx_domains(builder.env): + publisher.set_source(source_path=builder.env.doc2path(docname)) + publisher.publish() + return publisher.document + + +@pytest.mark.sphinx('text', testroot='object-description-sections') +def test_object_description_sections(app): + doctree = _doctree_for_test(app.builder, 'index') + # <document> + # <index> + # <desc> + # <desc_signature> + # <desc_name> + # func + # <desc_parameterlist> + # <desc_content> + # <section> + # <title> + # Overview + # <paragraph> + # Lorem ipsum dolar sit amet + + assert isinstance(doctree[0], addnodes.index) + assert isinstance(doctree[1], addnodes.desc) + assert isinstance(doctree[1][0], addnodes.desc_signature) + assert isinstance(doctree[1][1], addnodes.desc_content) + assert isinstance(doctree[1][1][0], nodes.section) + assert isinstance(doctree[1][1][0][0], nodes.title) + assert doctree[1][1][0][0][0] == 'Overview' + assert isinstance(doctree[1][1][0][1], nodes.paragraph) + assert doctree[1][1][0][1][0] == 'Lorem ipsum dolar sit amet' |