diff options
| author | Jon Dufresne <jon.dufresne@gmail.com> | 2018-12-11 06:46:04 -0800 |
|---|---|---|
| committer | Jon Dufresne <jon.dufresne@gmail.com> | 2018-12-11 06:50:20 -0800 |
| commit | 8bb73c9fd3555deb83f01e1d18fa10c563202f78 (patch) | |
| tree | affde9d2c1580e38138c860cd298b384cfde5b96 /sphinx/builders/changes.py | |
| parent | 689b9ffd047b12b0fe30e2b25bbc3f50f4756785 (diff) | |
| download | sphinx-git-8bb73c9fd3555deb83f01e1d18fa10c563202f78.tar.gz | |
Simplify open() call by removing default mode
The open() function opens files in read-only text mode by default. Drop
the mode argument to be slightly simpler and more idiomatic.
https://docs.python.org/3/library/functions.html#open
> The default mode is 'r' (open for reading text, synonym of 'rt').
Diffstat (limited to 'sphinx/builders/changes.py')
| -rw-r--r-- | sphinx/builders/changes.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sphinx/builders/changes.py b/sphinx/builders/changes.py index cf68e5dfa..5bf6ad6bb 100644 --- a/sphinx/builders/changes.py +++ b/sphinx/builders/changes.py @@ -135,7 +135,7 @@ class ChangesBuilder(Builder): logger.info(bold(__('copying source files...'))) for docname in self.env.all_docs: - with open(self.env.doc2path(docname), 'r', # type: ignore + with open(self.env.doc2path(docname), # type: ignore encoding=self.env.config.source_encoding) as f: try: lines = f.readlines() |