Fix mypy violations

1 files changed, 17 insertions, 1 deletions

diff --git a/sphinx/builders/htmlhelp.py b/sphinx/builders/htmlhelp.py
index 68fd3b1db..338015aca 100644
--- a/sphinx/builders/htmlhelp.py
+++ b/sphinx/builders/htmlhelp.py
@@ -24,6 +24,11 @@ from sphinx.util import logging
 from sphinx.util.osutil import make_filename
 from sphinx.util.pycompat import htmlescape
 
+if False:
+    # For type annotation
+    from typing import Any, IO, Tuple  # NOQA
+    from sphinx.application import Sphinx  # NOQA
+
 
 logger = logging.getLogger(__name__)
 
@@ -186,6 +191,7 @@ class HTMLHelpBuilder(StandaloneHTMLBuilder):
     encoding = 'cp1252'
 
     def init(self):
+        # type: () -> None
         StandaloneHTMLBuilder.init(self)
         # the output files for HTML help must be .html only
         self.out_suffix = '.html'
@@ -196,17 +202,21 @@ class HTMLHelpBuilder(StandaloneHTMLBuilder):
             self.lcid, self.encoding = locale
 
     def open_file(self, outdir, basename, mode='w'):
+        # type: (unicode, unicode, unicode) -> IO
         # open a file with the correct encoding for the selected language
-        return codecs.open(path.join(outdir, basename), mode,
+        return codecs.open(path.join(outdir, basename), mode,  # type: ignore
                            self.encoding, 'xmlcharrefreplace')
 
     def update_page_context(self, pagename, templatename, ctx, event_arg):
+        # type: (unicode, unicode, Dict, unicode) -> None
         ctx['encoding'] = self.encoding
 
     def handle_finish(self):
+        # type: () -> None
         self.build_hhx(self.outdir, self.config.htmlhelp_basename)
 
     def write_doc(self, docname, doctree):
+        # type: (unicode, nodes.Node) -> None
         for node in doctree.traverse(nodes.reference):
             # add ``target=_blank`` attributes to external links
             if node.get('internal') is None and 'refuri' in node:
@@ -215,6 +225,7 @@ class HTMLHelpBuilder(StandaloneHTMLBuilder):
         StandaloneHTMLBuilder.write_doc(self, docname, doctree)
 
     def build_hhx(self, outdir, outname):
+        # type: (unicode, unicode) -> None
         logger.info('dumping stopword list...')
         with self.open_file(outdir, outname + '.stp') as f:
             for word in sorted(stopwords):
@@ -255,6 +266,7 @@ class HTMLHelpBuilder(StandaloneHTMLBuilder):
                 self.config.master_doc, self, prune_toctrees=False)
 
             def write_toc(node, ullevel=0):
+                # type: (nodes.Node, int) -> None
                 if isinstance(node, nodes.list_item):
                     f.write('<LI> ')
                     for subnode in node:
@@ -275,6 +287,7 @@ class HTMLHelpBuilder(StandaloneHTMLBuilder):
                         write_toc(subnode, ullevel)
 
             def istoctree(node):
+                # type: (nodes.Node) -> bool
                 return isinstance(node, addnodes.compact_paragraph) and \
                     'toctree' in node
             for node in tocdoc.traverse(istoctree):
@@ -287,7 +300,9 @@ class HTMLHelpBuilder(StandaloneHTMLBuilder):
             f.write('<UL>\n')
 
             def write_index(title, refs, subitems):
+                # type: (unicode, List[Tuple[unicode, unicode]], List[Tuple[unicode, List[Tuple[unicode, unicode]]]]) -> None  # NOQA
                 def write_param(name, value):
+                    # type: (unicode, unicode) -> None
                     item = '    <param name="%s" value="%s">\n' % \
                         (name, value)
                     f.write(item)
@@ -316,6 +331,7 @@ class HTMLHelpBuilder(StandaloneHTMLBuilder):
 
 
 def setup(app):
+    # type: (Sphinx) -> Dict[unicode, Any]
     app.setup_extension('sphinx.builders.html')
     app.add_builder(HTMLHelpBuilder)