diff options
| author | Arie Bovenberg <a.c.bovenberg@gmail.com> | 2022-02-06 16:37:02 -0500 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2022-02-07 13:51:11 -0500 |
| commit | 38cdd3946c337f3d917218cd1c8da67a971646ee (patch) | |
| tree | b84f1588556cfd62b67d629dc8db6d61c6f4870b /.github/workflows | |
| parent | 0566df2f79c7aae978bc0ef8e253cfcc4de54ecc (diff) | |
| download | sqlalchemy-38cdd3946c337f3d917218cd1c8da67a971646ee.tar.gz | |
add slotscheck to CI
As discussed in #7589, `slotscheck` can prevent slots-related mistakes from creeping back in.
Plan for now is to have slotscheck part of the "lint" tests
(renamed from pep8) that will run for CI and github actions.
To support slotscheck's runtime nature, slotscheck is
run twice, first with cython exts enabled and then
with them disabled via new environment variable.
Also added sqlalchemy[mypy] dependency to support slots
checking the mypy plugin.
Found and fixed one more `__slots__` issue by disabling C
exts.
Closes: #7670
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/7670
Pull-request-sha: 3e77fe5449615a3c7c61ce9a1e4e79cd6636a89a
Change-Id: I90cdd284cdcee316a38856ba94d72ffc98947c5a
Diffstat (limited to '.github/workflows')
| -rw-r--r-- | .github/workflows/run-on-pr.yaml | 6 | ||||
| -rw-r--r-- | .github/workflows/run-test.yaml | 6 |
2 files changed, 6 insertions, 6 deletions
diff --git a/.github/workflows/run-on-pr.yaml b/.github/workflows/run-on-pr.yaml index 94db88ba0..45f62d772 100644 --- a/.github/workflows/run-on-pr.yaml +++ b/.github/workflows/run-on-pr.yaml @@ -84,8 +84,8 @@ jobs: - name: Run tests run: tox -e mypy ${{ matrix.pytest-args }} - run-pep8: - name: pep8-${{ matrix.python-version }} + run-lint: + name: lint-${{ matrix.python-version }} runs-on: ${{ matrix.os }} strategy: # run this job using this matrix, excluding some combinations below. @@ -115,7 +115,7 @@ jobs: pip list - name: Run tests - run: tox -e pep8 + run: tox -e lint # Arm emulation is quite slow (~20min) so for now just run it when merging to main # run-test-arm64: diff --git a/.github/workflows/run-test.yaml b/.github/workflows/run-test.yaml index 196e3c1b1..677721d7a 100644 --- a/.github/workflows/run-test.yaml +++ b/.github/workflows/run-test.yaml @@ -156,8 +156,8 @@ jobs: - name: Run tests run: tox -e mypy ${{ matrix.pytest-args }} - run-pep8: - name: pep8-${{ matrix.python-version }} + run-lint: + name: lint-${{ matrix.python-version }} runs-on: ${{ matrix.os }} strategy: # run this job using this matrix, excluding some combinations below. @@ -187,7 +187,7 @@ jobs: pip list - name: Run tests - run: tox -e pep8 + run: tox -e lint run-pep484: name: pep484-${{ matrix.python-version }} |