summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2013-08-04 15:28:40 -0400
committerMike Bayer <mike_mp@zzzcomputing.com>2013-08-04 15:28:40 -0400
commit1a88a982b43f2f3a0735890b00a45e178727812f (patch)
treea5a49a6bc15261cc3d44a879cbe857f408517c3f
parent9a49e09d0bae23bde869842c1444b65dc7e58c3d (diff)
downloadsqlalchemy-1a88a982b43f2f3a0735890b00a45e178727812f.tar.gz
find some more inline imports and move them out
-rw-r--r--lib/sqlalchemy/engine/url.py2
-rw-r--r--lib/sqlalchemy/orm/loading.py4
-rw-r--r--lib/sqlalchemy/orm/properties.py2
-rw-r--r--lib/sqlalchemy/orm/query.py2
-rw-r--r--lib/sqlalchemy/orm/strategies.py1
-rw-r--r--lib/sqlalchemy/schema.py7
6 files changed, 8 insertions, 10 deletions
diff --git a/lib/sqlalchemy/engine/url.py b/lib/sqlalchemy/engine/url.py
index ed5729eea..717eb54e1 100644
--- a/lib/sqlalchemy/engine/url.py
+++ b/lib/sqlalchemy/engine/url.py
@@ -16,6 +16,7 @@ be used directly and is also accepted directly by ``create_engine()``.
import re
from .. import exc, util
from . import Dialect
+from ..dialects import registry
class URL(object):
@@ -102,7 +103,6 @@ class URL(object):
name = self.drivername
else:
name = self.drivername.replace('+', '.')
- from sqlalchemy.dialects import registry
cls = registry.load(name)
# check for legacy dialects that
# would return a module with 'dialect' as the
diff --git a/lib/sqlalchemy/orm/loading.py b/lib/sqlalchemy/orm/loading.py
index 1641f509e..c219ea096 100644
--- a/lib/sqlalchemy/orm/loading.py
+++ b/lib/sqlalchemy/orm/loading.py
@@ -19,6 +19,8 @@ from .interfaces import EXT_CONTINUE
from ..sql import util as sql_util
from .util import _none_set, state_str
from .. import exc as sa_exc
+
+querylib = util.importlater("sqlalchemy.orm", "query")
sessionlib = util.importlater("sqlalchemy.orm", "session")
_new_runid = util.counter()
@@ -101,8 +103,6 @@ def instances(query, cursor, context):
def merge_result(query, iterator, load=True):
"""Merge a result into this :class:`.Query` object's Session."""
- from . import query as querylib
-
session = query.session
if load:
# flush current contents if we expect to load data
diff --git a/lib/sqlalchemy/orm/properties.py b/lib/sqlalchemy/orm/properties.py
index 5986556db..1bc2cff05 100644
--- a/lib/sqlalchemy/orm/properties.py
+++ b/lib/sqlalchemy/orm/properties.py
@@ -24,6 +24,7 @@ from .util import CascadeOptions, \
from .interfaces import MANYTOMANY, MANYTOONE, ONETOMANY,\
PropComparator, StrategizedProperty
+dynamic = util.importlater("sqlalchemy.orm", "dynamic")
mapperlib = util.importlater("sqlalchemy.orm", "mapperlib")
NoneType = type(None)
@@ -300,7 +301,6 @@ class RelationshipProperty(StrategizedProperty):
if strategy_class:
self.strategy_class = strategy_class
elif self.lazy == 'dynamic':
- from sqlalchemy.orm import dynamic
self.strategy_class = dynamic.DynaLoader
else:
self.strategy_class = strategies.factory(self.lazy)
diff --git a/lib/sqlalchemy/orm/query.py b/lib/sqlalchemy/orm/query.py
index f6fd07e61..5ed63916a 100644
--- a/lib/sqlalchemy/orm/query.py
+++ b/lib/sqlalchemy/orm/query.py
@@ -36,6 +36,7 @@ from ..sql import (
util as sql_util,
expression, visitors
)
+properties = util.importlater("sqlalchemy.orm", "properties")
__all__ = ['Query', 'QueryContext', 'aliased']
@@ -903,7 +904,6 @@ class Query(object):
"""
if property is None:
- from sqlalchemy.orm import properties
mapper = object_mapper(instance)
for prop in mapper.iterate_properties:
diff --git a/lib/sqlalchemy/orm/strategies.py b/lib/sqlalchemy/orm/strategies.py
index aa46d06a8..fac8a3c6f 100644
--- a/lib/sqlalchemy/orm/strategies.py
+++ b/lib/sqlalchemy/orm/strategies.py
@@ -350,7 +350,6 @@ class LazyLoader(AbstractRelationshipLoader):
# determine if our "lazywhere" clause is the same as the mapper's
# get() clause. then we can just use mapper.get()
- #from sqlalchemy.orm import query
self.use_get = not self.uselist and \
self.mapper._get_clause[0].compare(
self._lazywhere,
diff --git a/lib/sqlalchemy/schema.py b/lib/sqlalchemy/schema.py
index ebcc9a7ed..83d99f9c3 100644
--- a/lib/sqlalchemy/schema.py
+++ b/lib/sqlalchemy/schema.py
@@ -33,6 +33,7 @@ import inspect
from . import exc, util, dialects, event, events, inspection
from .sql import expression, visitors
import collections
+import sqlalchemy
ddl = util.importlater("sqlalchemy.engine", "ddl")
sqlutil = util.importlater("sqlalchemy.sql", "util")
@@ -2741,8 +2742,7 @@ class MetaData(SchemaItem):
"""Bind this MetaData to an Engine, Connection, string or URL."""
if isinstance(bind, util.string_types + (url.URL, )):
- from sqlalchemy import create_engine
- self._bind = create_engine(bind)
+ self._bind = sqlalchemy.create_engine(bind)
else:
self._bind = bind
bind = property(bind, _bind_to)
@@ -2971,8 +2971,7 @@ class ThreadLocalMetaData(MetaData):
try:
self.context._engine = self.__engines[bind]
except KeyError:
- from sqlalchemy import create_engine
- e = create_engine(bind)
+ e = sqlalchemy.create_engine(bind)
self.__engines[bind] = e
self.context._engine = e
else: