diff options
| author | Mike Bayer <mike_mp@zzzcomputing.com> | 2020-04-10 16:58:41 -0400 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2020-04-10 16:58:41 -0400 |
| commit | e228b4143274152aae599b3dbbcaa4ad7178147b (patch) | |
| tree | 29758acc6c42ab25781706bab5be49487f9687b3 | |
| parent | aff41b2384e64c6d9739626791603a2becf0126c (diff) | |
| download | sqlalchemy-e228b4143274152aae599b3dbbcaa4ad7178147b.tar.gz | |
Use define_tables for IsOrIsNotDistinctFromTest
In Ie8127ef29f1ec91e7afb88e1429538c27a321784 Mike
failed to notice that this test is build on TablesTest and
has just the one test function, which means the table is
built up by the fixture.
Change-Id: I855431bc976fe8ec96559ec1a22bb294aecf3c40
| -rw-r--r-- | lib/sqlalchemy/testing/suite/test_select.py | 22 |
1 files changed, 12 insertions, 10 deletions
diff --git a/lib/sqlalchemy/testing/suite/test_select.py b/lib/sqlalchemy/testing/suite/test_select.py index 2c2317ff7..852bfcf0d 100644 --- a/lib/sqlalchemy/testing/suite/test_select.py +++ b/lib/sqlalchemy/testing/suite/test_select.py @@ -1015,7 +1015,16 @@ class IsOrIsNotDistinctFromTest(fixtures.TablesTest): __backend__ = True __requires__ = ("supports_is_distinct_from",) - @testing.provide_metadata + @classmethod + def define_tables(cls, metadata): + Table( + "is_distinct_test", + metadata, + Column("id", Integer, primary_key=True), + Column("col_a", Integer, nullable=True), + Column("col_b", Integer, nullable=True), + ) + @testing.combinations( ("both_int_different", 0, 1, 1), ("both_int_same", 1, 1, 0), @@ -1028,15 +1037,8 @@ class IsOrIsNotDistinctFromTest(fixtures.TablesTest): def test_is_or_isnot_distinct_from( self, col_a_value, col_b_value, expected_row_count_for_is, connection ): - meta = self.metadata - tbl = Table( - "is_distinct_test", - meta, - Column("id", Integer, primary_key=True), - Column("col_a", Integer, nullable=True), - Column("col_b", Integer, nullable=True), - ) - meta.create_all() + tbl = self.tables.is_distinct_test + connection.execute( tbl.insert(), [{"id": 1, "col_a": col_a_value, "col_b": col_b_value}], |
