summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/sql
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2008-01-07 18:52:02 +0000
committerMike Bayer <mike_mp@zzzcomputing.com>2008-01-07 18:52:02 +0000
commite8feacf1db658ecccf7bb1d1688662e701ad37f5 (patch)
tree9506104355f841bea36526cd6c66b4f5e21639e5 /lib/sqlalchemy/sql
parentacd13f99f18ad02b2e51e8be7303124e40c55473 (diff)
downloadsqlalchemy-e8feacf1db658ecccf7bb1d1688662e701ad37f5.tar.gz
- fixed an attribute history bug whereby assigning a new collection
to a collection-based attribute which already had pending changes would generate incorrect history [ticket:922] - fixed delete-orphan cascade bug whereby setting the same object twice to a scalar attribute could log it as an orphan [ticket:925] - generative select.order_by(None) / group_by(None) was not managing to reset order by/group by criterion, fixed [ticket:924]
Diffstat (limited to 'lib/sqlalchemy/sql')
-rw-r--r--lib/sqlalchemy/sql/expression.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/sqlalchemy/sql/expression.py b/lib/sqlalchemy/sql/expression.py
index b3b04b678..3dc7242d7 100644
--- a/lib/sqlalchemy/sql/expression.py
+++ b/lib/sqlalchemy/sql/expression.py
@@ -2815,7 +2815,7 @@ class _SelectBaseMixin(object):
form of this method instead to prevent this issue.
"""
- if clauses == [None]:
+ if len(clauses) == 1 and clauses[0] is None:
self._order_by_clause = ClauseList()
else:
if getattr(self, '_order_by_clause', None):
@@ -2833,7 +2833,7 @@ class _SelectBaseMixin(object):
form of this method instead to prevent this issue.
"""
- if clauses == [None]:
+ if len(clauses) == 1 and clauses[0] is None:
self._group_by_clause = ClauseList()
else:
if getattr(self, '_group_by_clause', None):