summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/testing/suite/test_reflection.py
diff options
context:
space:
mode:
authorGord Thompson <gord@gordthompson.com>2020-01-12 20:08:22 -0500
committerGord Thompson <gord@gordthompson.com>2020-01-26 09:49:20 -0700
commit6fb7b527426b564302d6fd8ca11dfa7b78cc2e7a (patch)
treea7f0329e12d84329a265a083b0b5b4e0fd49fa93 /lib/sqlalchemy/testing/suite/test_reflection.py
parent411637fbcf679f36448f1b094afef375158df15e (diff)
downloadsqlalchemy-6fb7b527426b564302d6fd8ca11dfa7b78cc2e7a.tar.gz
Refactor test provisioning to dialect-level files
Fixes: #5085 <!-- Provide a general summary of your proposed changes in the Title field above --> Move dialect-specific provisioning code to dialect-level copies of provision.py. <!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the PR is submitted, so no need to do everything at once) --> This pull request is: - [ ] A documentation / typographical error fix - Good to go, no issue or tests are needed - [x] A short code fix - please include the issue number, and create an issue if none exists, which must include a complete example of the issue. one line code fixes without an issue and demonstration will not be accepted. - Please include: `Fixes: #<issue number>` in the commit message - please include tests. one line code fixes without tests will not be accepted. - [ ] A new feature implementation - please include the issue number, and create an issue if none exists, which must include a complete example of how the feature would look. - Please include: `Fixes: #<issue number>` in the commit message - please include tests. **Have a nice day!** Closes: #5092 Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/5092 Pull-request-sha: 25b9b7a9800549fb823576af8674e8d33ff4b2c1 Change-Id: Ie0b4a69aa472a60bdbd825e04c8595382bcc98e1
Diffstat (limited to 'lib/sqlalchemy/testing/suite/test_reflection.py')
-rw-r--r--lib/sqlalchemy/testing/suite/test_reflection.py12
1 files changed, 2 insertions, 10 deletions
diff --git a/lib/sqlalchemy/testing/suite/test_reflection.py b/lib/sqlalchemy/testing/suite/test_reflection.py
index 85e193d8e..f9ff46492 100644
--- a/lib/sqlalchemy/testing/suite/test_reflection.py
+++ b/lib/sqlalchemy/testing/suite/test_reflection.py
@@ -9,6 +9,7 @@ from .. import eq_
from .. import expect_warnings
from .. import fixtures
from .. import is_
+from ..provision import temp_table_keyword_args
from ..schema import Column
from ..schema import Table
from ... import event
@@ -304,16 +305,7 @@ class ComponentReflectionTest(fixtures.TablesTest):
@classmethod
def define_temp_tables(cls, metadata):
- # cheat a bit, we should fix this with some dialect-level
- # temp table fixture
- if testing.against("oracle"):
- kw = {
- "prefixes": ["GLOBAL TEMPORARY"],
- "oracle_on_commit": "PRESERVE ROWS",
- }
- else:
- kw = {"prefixes": ["TEMPORARY"]}
-
+ kw = temp_table_keyword_args(config, config.db)
user_tmp = Table(
"user_tmp",
metadata,