diff options
| author | Mike Bayer <mike_mp@zzzcomputing.com> | 2018-01-04 10:44:53 -0500 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2018-01-04 10:44:53 -0500 |
| commit | 43c7c4f347fa6a5a6493bd03e2233fd5d14aee9e (patch) | |
| tree | 7b0b5e90363e9fb4e11d05bfb62445992edc39f0 /lib/sqlalchemy/testing | |
| parent | 435aaff20effbc914bbb4d19f177df3c1f5f15ab (diff) | |
| download | sqlalchemy-43c7c4f347fa6a5a6493bd03e2233fd5d14aee9e.tar.gz | |
Add rule to prevent "GROUP BY <expr>" in tests
Added a new exclusion rule group_by_complex_expression
which disables tests that use "GROUP BY <expr>", which seems
to be not viable for at least two third party dialects.
Change-Id: I47284513382ae93f5a3d12c734b3a44643147c99
Diffstat (limited to 'lib/sqlalchemy/testing')
| -rw-r--r-- | lib/sqlalchemy/testing/requirements.py | 11 | ||||
| -rw-r--r-- | lib/sqlalchemy/testing/suite/test_select.py | 1 |
2 files changed, 12 insertions, 0 deletions
diff --git a/lib/sqlalchemy/testing/requirements.py b/lib/sqlalchemy/testing/requirements.py index 0b89a4506..b89d149d6 100644 --- a/lib/sqlalchemy/testing/requirements.py +++ b/lib/sqlalchemy/testing/requirements.py @@ -206,6 +206,17 @@ class SuiteRequirements(Requirements): return exclusions.open() + @property + def group_by_complex_expression(self): + """target platform supports SQL expressions in GROUP BY + + e.g. + + SELECT x + y AS somelabel FROM table GROUP BY x + y + + """ + + return exclusions.open() @property def sane_rowcount(self): diff --git a/lib/sqlalchemy/testing/suite/test_select.py b/lib/sqlalchemy/testing/suite/test_select.py index 097214823..df638c140 100644 --- a/lib/sqlalchemy/testing/suite/test_select.py +++ b/lib/sqlalchemy/testing/suite/test_select.py @@ -87,6 +87,7 @@ class OrderByLabelTest(fixtures.TablesTest): [(7, ), (5, ), (3, )] ) + @testing.requires.group_by_complex_expression def test_group_by_composed(self): table = self.tables.some_table expr = (table.c.x + table.c.y).label('lx') |
