Add deprecation warnings to all deprecated APIs

A large change throughout the library has ensured that all objects, parameters,
and behaviors which have been noted as deprecated or legacy now emit
``DeprecationWarning`` warnings when invoked.   As the Python 3 interpreter now
defaults to displaying deprecation warnings, as well as that modern test suites
based on tools like tox and pytest tend to display deprecation warnings,
this change should make it easier to note what API features are obsolete.

See the notes added to the changelog and migration notes for further
details.

Fixes: #4393
Change-Id: If0ea11a1fc24f9a8029352eeadfc49a7a54c0a1b

4 files changed, 15 insertions, 14 deletions

diff --git a/lib/sqlalchemy/testing/engines.py b/lib/sqlalchemy/testing/engines.py
index 22faa2394..232eebeb3 100644
--- a/lib/sqlalchemy/testing/engines.py
+++ b/lib/sqlalchemy/testing/engines.py
@@ -12,6 +12,7 @@ import warnings
 import weakref
 
 from . import config
+from . import uses_deprecated
 from .util import decorator
 from .. import event
 from .. import pool
@@ -74,6 +75,7 @@ class ConnectionKiller(object):
         else:
             self._stop_test_ctx_aggressive()
 
+    @uses_deprecated()
     def _stop_test_ctx_minimal(self):
         self.close_all()
 
@@ -83,6 +85,7 @@ class ConnectionKiller(object):
             if rec is not config.db:
                 rec.dispose()
 
+    @uses_deprecated()
     def _stop_test_ctx_aggressive(self):
         self.close_all()
         for conn, rec in list(self.conns):
diff --git a/lib/sqlalchemy/testing/suite/test_reflection.py b/lib/sqlalchemy/testing/suite/test_reflection.py
index aa04b6073..e8d75bafa 100644
--- a/lib/sqlalchemy/testing/suite/test_reflection.py
+++ b/lib/sqlalchemy/testing/suite/test_reflection.py
@@ -313,11 +313,15 @@ class ComponentReflectionTest(fixtures.TablesTest):
             answer = ["email_addresses_v", "users_v"]
             eq_(sorted(table_names), answer)
         else:
-            table_names = [
-                t
-                for t in insp.get_table_names(schema, order_by=order_by)
-                if t not in _ignore_tables
-            ]
+            if order_by:
+                tables = [
+                    rec[0]
+                    for rec in insp.get_sorted_table_and_fkc_names(schema)
+                    if rec[0]
+                ]
+            else:
+                tables = insp.get_table_names(schema)
+            table_names = [t for t in tables if t not in _ignore_tables]
 
             if order_by == "foreign_key":
                 answer = ["users", "email_addresses", "dingalings"]
diff --git a/lib/sqlalchemy/testing/suite/test_results.py b/lib/sqlalchemy/testing/suite/test_results.py
index aa98a5088..a07e45df2 100644
--- a/lib/sqlalchemy/testing/suite/test_results.py
+++ b/lib/sqlalchemy/testing/suite/test_results.py
@@ -320,7 +320,7 @@ class ServerSideCursorsTest(
 
     def test_for_update_expr(self):
         engine = self._fixture(True)
-        s1 = select([1], for_update=True)
+        s1 = select([1]).with_for_update()
         result = engine.execute(s1)
         assert self._is_server_side(result.cursor)
 
diff --git a/lib/sqlalchemy/testing/suite/test_types.py b/lib/sqlalchemy/testing/suite/test_types.py
index 4791671f3..1e02c0e74 100644
--- a/lib/sqlalchemy/testing/suite/test_types.py
+++ b/lib/sqlalchemy/testing/suite/test_types.py
@@ -933,10 +933,7 @@ class JSONTest(_LiteralRoundTripFixture, fixtures.TablesTest):
         )
         eq_(
             s.query(
-                cast(
-                    self.tables.data_table.c.data,
-                    String(convert_unicode="force"),
-                ),
+                cast(self.tables.data_table.c.data, String()),
                 cast(self.tables.data_table.c.nulldata, String),
             )
             .filter(self.tables.data_table.c.name == "d1")
@@ -945,10 +942,7 @@ class JSONTest(_LiteralRoundTripFixture, fixtures.TablesTest):
         )
         eq_(
             s.query(
-                cast(
-                    self.tables.data_table.c.data,
-                    String(convert_unicode="force"),
-                ),
+                cast(self.tables.data_table.c.data, String()),
                 cast(self.tables.data_table.c.nulldata, String),
             )
             .filter(self.tables.data_table.c.name == "d2")