summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy
diff options
context:
space:
mode:
authorj00356287 <jiajunsu@huawei.com>2019-09-05 11:50:13 -0400
committersqla-tester <sqla-tester@sqlalchemy.org>2019-09-05 11:50:13 -0400
commit129a9ded7bbb7faa3427d5e2605ee4ab78255ea0 (patch)
treee2b91c44a71a6d9443697546437a0c2265ddf754 /lib/sqlalchemy
parent75c3950732a66ff7f4aca152653d6cb14eb9783c (diff)
downloadsqlalchemy-129a9ded7bbb7faa3427d5e2605ee4ab78255ea0.tar.gz
Improve testcase condition statement for dialects
We could get dialect.requires_name_normalize rather than use hard code as "firebird" or "oracle", since we have add `normalize` attribute for quite a long time. ### Description Use `dialect.requires_name_normalize` instead `testing.against("firebird", "oracle")` ### Checklist <!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the PR is submitted, so no need to do everything at once) --> This pull request is: - [ ] A documentation / typographical error fix - Good to go, no issue or tests are needed - [x] A short code fix - please include the issue number, and create an issue if none exists, which must include a complete example of the issue. one line code fixes without an issue and demonstration will not be accepted. - Please include: `Fixes: #<issue number>` in the commit message - please include tests. one line code fixes without tests will not be accepted. - [ ] A new feature implementation - please include the issue number, and create an issue if none exists, which must include a complete example of how the feature would look. - Please include: `Fixes: #<issue number>` in the commit message - please include tests. **Have a nice day!** Closes: #4843 Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/4843 Pull-request-sha: 304fe67b06c1f010a164806a12b68cfce9bd0d2b Change-Id: I276f781482779473258f9269074847e283711b05
Diffstat (limited to 'lib/sqlalchemy')
0 files changed, 0 insertions, 0 deletions