summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2010-06-14 20:07:44 -0400
committerMike Bayer <mike_mp@zzzcomputing.com>2010-06-14 20:07:44 -0400
commit7a554d526745d6327e112460ea75f50d9ff2105f (patch)
tree54866c6b966dd0c7d9d65bcad08f0571fb28daa7 /lib/sqlalchemy
parent33f6dcc80b43e499562991d7bfaf4f896d55f445 (diff)
downloadsqlalchemy-7a554d526745d6327e112460ea75f50d9ff2105f.tar.gz
- Query.statement, Query.subquery(), etc. now transfer
the values of bind parameters, i.e. those specified by query.params(), into the resulting SQL expression. Previously the values would not be transferred and bind parameters would come out as None. - Subquery-eager-loading now works with Query objects which include params(), as well as get() Queries.
Diffstat (limited to 'lib/sqlalchemy')
-rw-r--r--lib/sqlalchemy/orm/query.py7
-rw-r--r--lib/sqlalchemy/orm/strategies.py1
2 files changed, 6 insertions, 2 deletions
diff --git a/lib/sqlalchemy/orm/query.py b/lib/sqlalchemy/orm/query.py
index ae6624d47..50be13088 100644
--- a/lib/sqlalchemy/orm/query.py
+++ b/lib/sqlalchemy/orm/query.py
@@ -399,8 +399,11 @@ class Query(object):
"""
- return self._compile_context(labels=self._with_labels).\
- statement._annotate({'_halt_adapt': True})
+ stmt = self._compile_context(labels=self._with_labels).\
+ statement
+ if self._params:
+ stmt = stmt.params(self._params)
+ return stmt._annotate({'_halt_adapt': True})
def subquery(self):
"""return the full SELECT statement represented by this Query,
diff --git a/lib/sqlalchemy/orm/strategies.py b/lib/sqlalchemy/orm/strategies.py
index 5b5dd312d..62602ff37 100644
--- a/lib/sqlalchemy/orm/strategies.py
+++ b/lib/sqlalchemy/orm/strategies.py
@@ -700,6 +700,7 @@ class SubqueryLoader(AbstractRelationshipLoader):
# reformat the original query
# to look only for significant columns
q = orig_query._clone()
+
# TODO: why does polymporphic etc. require hardcoding
# into _adapt_col_list ? Does query.add_columns(...) work
# with polymorphic loading ?