diff options
| author | Mike Bayer <mike_mp@zzzcomputing.com> | 2011-04-22 18:33:55 -0400 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2011-04-22 18:33:55 -0400 |
| commit | eb569b672bada027f5cfe7c918c91affeb9c61b0 (patch) | |
| tree | a6138eb5957e7dd3f3b7c8c2f19ee6d54e4da8d7 /lib/sqlalchemy | |
| parent | 5b8a84ea4444c8d0e8aa4c2b9565e019cfa245a1 (diff) | |
| download | sqlalchemy-eb569b672bada027f5cfe7c918c91affeb9c61b0.tar.gz | |
- It is an error to call query.get() when the
given entity is not a single, full class
entity or mapper (i.e. a column). This is
a deprecation warning in 0.6.8.
[ticket:2144]
Diffstat (limited to 'lib/sqlalchemy')
| -rw-r--r-- | lib/sqlalchemy/orm/query.py | 16 | ||||
| -rw-r--r-- | lib/sqlalchemy/sql/compiler.py | 2 |
2 files changed, 14 insertions, 4 deletions
diff --git a/lib/sqlalchemy/orm/query.py b/lib/sqlalchemy/orm/query.py index 07df0de42..b7b2eccec 100644 --- a/lib/sqlalchemy/orm/query.py +++ b/lib/sqlalchemy/orm/query.py @@ -298,6 +298,18 @@ class Query(object): ) return self._mapper_zero() + def _only_full_mapper_zero(self, methname): + if len(self._entities) != 1: + raise sa_exc.InvalidRequestError( + "%s() can only be used against " + "a single mapped class." % methname) + entity = self._entity_zero() + if not hasattr(entity, 'primary_entity'): + raise sa_exc.InvalidRequestError( + "%s() can only be used against " + "a single mapped class." % methname) + return entity.entity_zero + def _only_entity_zero(self, rationale=None): if len(self._entities) > 1: raise sa_exc.InvalidRequestError( @@ -631,9 +643,7 @@ class Query(object): ident = util.to_list(ident) - mapper = self._only_mapper_zero( - "get() can only be used against a single mapped class." - ) + mapper = self._only_full_mapper_zero("get") if len(ident) != len(mapper.primary_key): raise sa_exc.InvalidRequestError( diff --git a/lib/sqlalchemy/sql/compiler.py b/lib/sqlalchemy/sql/compiler.py index 82c1748cc..829adebac 100644 --- a/lib/sqlalchemy/sql/compiler.py +++ b/lib/sqlalchemy/sql/compiler.py @@ -965,7 +965,7 @@ class SQLCompiler(engine.Compiled): if colparams or not supports_default_values: text += " (%s)" % ', '.join([preparer.format_column(c[0]) for c in colparams]) - + if self.returning or insert_stmt._returning: self.returning = self.returning or insert_stmt._returning returning_clause = self.returning_clause( |
