summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorMike Bayer <mike_mp@zzzcomputing.com>2017-03-14 13:38:12 -0400
committerMike Bayer <mike_mp@zzzcomputing.com>2017-03-14 13:38:12 -0400
commit596e322543df6ff380243c9cb0cf9997252329f6 (patch)
treedd4d95cad90679e20f069fe63b8c143a237fb667 /lib
parent2895c57b29c500fe4388ef23e61f13c5e1e9b4b2 (diff)
downloadsqlalchemy-596e322543df6ff380243c9cb0cf9997252329f6.tar.gz
Enable sane_multi_rowcount for cx_Oracle
Also add some tests to test_rowcount. Change-Id: Idaa18fdc4fcfeb615725531c37de77decf76a783 Fixes: #3932
Diffstat (limited to 'lib')
-rw-r--r--lib/sqlalchemy/dialects/oracle/base.py2
-rw-r--r--lib/sqlalchemy/dialects/oracle/cx_oracle.py5
2 files changed, 5 insertions, 2 deletions
diff --git a/lib/sqlalchemy/dialects/oracle/base.py b/lib/sqlalchemy/dialects/oracle/base.py
index 39bc5e1d3..8cafb3656 100644
--- a/lib/sqlalchemy/dialects/oracle/base.py
+++ b/lib/sqlalchemy/dialects/oracle/base.py
@@ -957,8 +957,6 @@ class OracleDialect(default.DefaultDialect):
supports_unicode_statements = False
supports_unicode_binds = False
max_identifier_length = 30
- supports_sane_rowcount = True
- supports_sane_multi_rowcount = False
supports_simple_order_by_label = False
diff --git a/lib/sqlalchemy/dialects/oracle/cx_oracle.py b/lib/sqlalchemy/dialects/oracle/cx_oracle.py
index 9b3e3b8a1..6789cd49f 100644
--- a/lib/sqlalchemy/dialects/oracle/cx_oracle.py
+++ b/lib/sqlalchemy/dialects/oracle/cx_oracle.py
@@ -653,6 +653,9 @@ class OracleDialect_cx_oracle(OracleDialect):
execution_ctx_cls = OracleExecutionContext_cx_oracle
statement_compiler = OracleCompiler_cx_oracle
+ supports_sane_rowcount = True
+ supports_sane_multi_rowcount = True
+
driver = "cx_oracle"
colspecs = colspecs = {
@@ -723,6 +726,8 @@ class OracleDialect_cx_oracle(OracleDialect):
self._cx_oracle_binary_types = types("BFILE", "CLOB", "NCLOB", "BLOB")
self.supports_unicode_binds = self.cx_oracle_ver >= (5, 0)
+ self.supports_sane_multi_rowcount = self.cx_oracle_ver >= (5, 0)
+
self.coerce_to_unicode = (
self.cx_oracle_ver >= (5, 0) and
coerce_to_unicode