diff options
| author | mike bayer <mike_mp@zzzcomputing.com> | 2022-09-24 01:02:16 +0000 |
|---|---|---|
| committer | Gerrit Code Review <gerrit@ci3.zzzcomputing.com> | 2022-09-24 01:02:16 +0000 |
| commit | beb4376c5eba11423c0be247aaa62ba18a666d54 (patch) | |
| tree | 5f3f73e115aca425e277764045098b52698785a2 /lib | |
| parent | 8e59de9cc180453470f2530a459ae8c248916288 (diff) | |
| parent | 3333c6623fa45bcbc7fabd061184a79b7b7f2fa6 (diff) | |
| download | sqlalchemy-beb4376c5eba11423c0be247aaa62ba18a666d54.tar.gz | |
Merge "Tighten password security by removing `URL.__str__`" into main
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/sqlalchemy/engine/url.py | 3 | ||||
| -rw-r--r-- | lib/sqlalchemy/testing/plugin/plugin_base.py | 5 | ||||
| -rw-r--r-- | lib/sqlalchemy/testing/provision.py | 4 |
3 files changed, 6 insertions, 6 deletions
diff --git a/lib/sqlalchemy/engine/url.py b/lib/sqlalchemy/engine/url.py index 8d80cfd1c..cca31edd0 100644 --- a/lib/sqlalchemy/engine/url.py +++ b/lib/sqlalchemy/engine/url.py @@ -642,9 +642,6 @@ class URL(NamedTuple): ) return s - def __str__(self) -> str: - return self.render_as_string(hide_password=False) - def __repr__(self) -> str: return self.render_as_string() diff --git a/lib/sqlalchemy/testing/plugin/plugin_base.py b/lib/sqlalchemy/testing/plugin/plugin_base.py index 494e7d5ab..b90a2ec58 100644 --- a/lib/sqlalchemy/testing/plugin/plugin_base.py +++ b/lib/sqlalchemy/testing/plugin/plugin_base.py @@ -436,7 +436,10 @@ def _engine_uri(options, file_config): if options.write_idents and provision.FOLLOWER_IDENT: with open(options.write_idents, "a") as file_: - file_.write(provision.FOLLOWER_IDENT + " " + db_url + "\n") + file_.write( + f"{provision.FOLLOWER_IDENT} " + f"{db_url.render_as_string(hide_password=False)}\n" + ) cfg = provision.setup_config( db_url, options, file_config, provision.FOLLOWER_IDENT diff --git a/lib/sqlalchemy/testing/provision.py b/lib/sqlalchemy/testing/provision.py index 12448b2fe..7ba89b505 100644 --- a/lib/sqlalchemy/testing/provision.py +++ b/lib/sqlalchemy/testing/provision.py @@ -167,7 +167,7 @@ def _generate_driver_urls(url, extra_drivers): extra_drivers.discard(main_driver) url = generate_driver_url(url, main_driver, "") - yield str(url) + yield url for drv in list(extra_drivers): @@ -183,7 +183,7 @@ def _generate_driver_urls(url, extra_drivers): if new_url: extra_drivers.remove(drv) - yield str(new_url) + yield new_url @register.init |
