diff options
| author | Mike Bayer <mike_mp@zzzcomputing.com> | 2018-03-07 16:27:26 -0500 |
|---|---|---|
| committer | Mike Bayer <mike_mp@zzzcomputing.com> | 2018-03-07 16:27:26 -0500 |
| commit | 4982a250a9b22795b47caf5fc42225689c1da919 (patch) | |
| tree | e614e8263fda5136e3e05197a1fb496628ec7f81 /test/dialect | |
| parent | c4fcf556528e787b1b3930671bf990538a8514d6 (diff) | |
| download | sqlalchemy-4982a250a9b22795b47caf5fc42225689c1da919.tar.gz | |
Raise cx_Oracle minimum version to 5.2
The minimum cx_Oracle version supported is 5.2 (June 2015). Previously,
the dialect asserted against version 5.0 but as of 1.2.2 we are using some
symbols that did not appear until 5.2.
Change-Id: I6fa4238f1722789924f4a6473fdce6f524333825
Fixes: #4211
Diffstat (limited to 'test/dialect')
| -rw-r--r-- | test/dialect/oracle/test_dialect.py | 19 |
1 files changed, 18 insertions, 1 deletions
diff --git a/test/dialect/oracle/test_dialect.py b/test/dialect/oracle/test_dialect.py index 83a875c2e..fc6eba89a 100644 --- a/test/dialect/oracle/test_dialect.py +++ b/test/dialect/oracle/test_dialect.py @@ -28,7 +28,8 @@ import datetime import os from sqlalchemy import sql from sqlalchemy.testing.mock import Mock - +from sqlalchemy.testing import mock +from sqlalchemy import exc class DialectTest(fixtures.TestBase): def test_cx_oracle_version_parse(self): @@ -49,6 +50,22 @@ class DialectTest(fixtures.TestBase): (6, 0) ) + def test_minimum_version(self): + with mock.patch( + "sqlalchemy.dialects.oracle.cx_oracle.OracleDialect_cx_oracle." + "_parse_cx_oracle_ver", lambda self, vers: (5, 1, 5)): + assert_raises_message( + exc.InvalidRequestError, + "cx_Oracle version 5.2 and above are supported", + cx_oracle.OracleDialect_cx_oracle, + dbapi=Mock() + ) + + with mock.patch( + "sqlalchemy.dialects.oracle.cx_oracle.OracleDialect_cx_oracle." + "_parse_cx_oracle_ver", lambda self, vers: (5, 3, 1)): + cx_oracle.OracleDialect_cx_oracle(dbapi=Mock()) + class OutParamTest(fixtures.TestBase, AssertsExecutionResults): __only_on__ = 'oracle+cx_oracle' |
