summaryrefslogtreecommitdiff
path: root/lib/sqlalchemy/cextension/utils.c
diff options
context:
space:
mode:
Diffstat (limited to 'lib/sqlalchemy/cextension/utils.c')
-rw-r--r--lib/sqlalchemy/cextension/utils.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/lib/sqlalchemy/cextension/utils.c b/lib/sqlalchemy/cextension/utils.c
index a437adc70..fb7fbe4e6 100644
--- a/lib/sqlalchemy/cextension/utils.c
+++ b/lib/sqlalchemy/cextension/utils.c
@@ -23,6 +23,9 @@ the MIT License: http://www.opensource.org/licenses/mit-license.php
static PyObject *
distill_params(PyObject *self, PyObject *args)
{
+ // TODO: pass the Connection in so that there can be a standard
+ // method for warning on parameter format
+
PyObject *multiparams, *params;
PyObject *enclosing_list, *double_enclosing_list;
PyObject *zero_element, *zero_element_item;
@@ -44,6 +47,8 @@ distill_params(PyObject *self, PyObject *args)
if (multiparam_size == 0) {
if (params != Py_None && PyDict_Size(params) != 0) {
+ // TODO: this is keyword parameters, emit parameter format
+ // deprecation warning
enclosing_list = PyList_New(1);
if (enclosing_list == NULL) {
return NULL;
@@ -152,6 +157,8 @@ distill_params(PyObject *self, PyObject *args)
}
}
else {
+ // TODO: this is multiple positional params, emit parameter format
+ // deprecation warning
zero_element = PyTuple_GetItem(multiparams, 0);
if (PyObject_HasAttrString(zero_element, "__iter__") &&
!PyObject_HasAttrString(zero_element, "strip")