1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
|
import sqlalchemy as sa
from sqlalchemy import ForeignKey
from sqlalchemy import Integer
from sqlalchemy import select
from sqlalchemy import String
from sqlalchemy import testing
from sqlalchemy.orm import immediateload
from sqlalchemy.orm import relationship
from sqlalchemy.orm import selectinload
from sqlalchemy.orm import Session
from sqlalchemy.testing import eq_
from sqlalchemy.testing import expect_raises_message
from sqlalchemy.testing import expect_warnings
from sqlalchemy.testing import fixtures
from sqlalchemy.testing.fixtures import fixture_session
from sqlalchemy.testing.schema import Column
from sqlalchemy.testing.schema import Table
from test.orm import _fixtures
class NonRecursiveTest(_fixtures.FixtureTest):
@classmethod
def setup_mappers(cls):
cls._setup_stock_mapping()
@testing.combinations(selectinload, immediateload, argnames="loader")
def test_no_recursion_depth_non_self_referential(self, loader):
User = self.classes.User
sess = fixture_session()
stmt = select(User).options(
selectinload(User.addresses, recursion_depth=-1)
)
with expect_raises_message(
sa.exc.InvalidRequestError,
"recursion_depth option on relationship User.addresses not valid",
):
sess.execute(stmt).all()
class _NodeTest:
@classmethod
def define_tables(cls, metadata):
Table(
"nodes",
metadata,
Column("id", Integer, primary_key=True),
Column("parent_id", Integer, ForeignKey("nodes.id")),
Column("data", String(30)),
)
@classmethod
def setup_mappers(cls):
nodes = cls.tables.nodes
Node = cls.classes.Node
cls.mapper_registry.map_imperatively(
Node,
nodes,
properties={"children": relationship(Node)},
)
@classmethod
def setup_classes(cls):
class Node(cls.Comparable):
def append(self, node):
self.children.append(node)
class ShallowRecursiveTest(_NodeTest, fixtures.MappedTest):
@classmethod
def insert_data(cls, connection):
Node = cls.classes.Node
n1 = Node(data="n1")
n1.append(Node(data="n11"))
n1.append(Node(data="n12"))
n1.append(Node(data="n13"))
n1.children[0].children = [Node(data="n111"), Node(data="n112")]
n1.children[1].append(Node(data="n121"))
n1.children[1].append(Node(data="n122"))
n1.children[1].append(Node(data="n123"))
n2 = Node(data="n2")
n2.append(Node(data="n21"))
n2.children[0].append(Node(data="n211"))
n2.children[0].append(Node(data="n212"))
with Session(connection) as sess:
sess.add(n1)
sess.add(n2)
sess.commit()
@testing.fixture
def data_fixture(self):
Node = self.classes.Node
def go(sess):
n1, n2 = sess.scalars(
select(Node)
.where(Node.data.in_(["n1", "n2"]))
.order_by(Node.id)
).all()
return n1, n2
return go
def _full_structure(self):
Node = self.classes.Node
return [
Node(
data="n1",
children=[
Node(data="n11"),
Node(
data="n12",
children=[
Node(data="n121"),
Node(data="n122"),
Node(data="n123"),
],
),
Node(data="n13"),
],
),
Node(
data="n2",
children=[
Node(
data="n21",
children=[
Node(data="n211"),
Node(data="n212"),
],
)
],
),
]
@testing.combinations(
(selectinload, 4),
(immediateload, 14),
argnames="loader,expected_sql_count",
)
def test_recursion_depth_opt(
self, data_fixture, loader, expected_sql_count
):
Node = self.classes.Node
sess = fixture_session()
n1, n2 = data_fixture(sess)
def go():
return (
sess.query(Node)
.filter(Node.data.in_(["n1", "n2"]))
.options(loader(Node.children, recursion_depth=-1))
.order_by(Node.data)
.all()
)
result = self.assert_sql_count(testing.db, go, expected_sql_count)
sess.close()
eq_(result, self._full_structure())
class DeepRecursiveTest(_NodeTest, fixtures.MappedTest):
@classmethod
def insert_data(cls, connection):
nodes = cls.tables.nodes
connection.execute(
nodes.insert(),
[
{"id": i, "parent_id": i - 1 if i > 1 else None}
for i in range(1, 201)
],
)
connection.commit()
@testing.fixture
def limited_cache_conn(self, connection):
connection.engine._compiled_cache.clear()
assert_limit = 0
def go(limit):
nonlocal assert_limit
assert_limit = limit
return connection
yield go
clen = len(connection.engine._compiled_cache)
# make sure we used the cache
assert clen > 1
# make sure it didn't grow much. current top is 6, as the loaders
# seem to generate a few times, i think there is some artifact
# in the cache key gen having to do w/ other things being memoized
# or not that causes it to generate a different cache key a few times,
# should figure out and document what that is
assert clen < assert_limit, f"cache grew to {clen}"
def _stack_loaders(self, loader_fn, depth):
Node = self.classes.Node
opt = loader_fn(Node.children)
while depth:
opt = getattr(opt, loader_fn.__name__)(Node.children)
depth -= 1
return opt
def _assert_depth(self, obj, depth):
stack = [obj]
depth += 1
while stack and depth:
n = stack.pop(0)
stack.extend(n.__dict__["children"])
depth -= 1
for n in stack:
assert "children" not in n.__dict__
@testing.combinations(selectinload, immediateload, argnames="loader_fn")
@testing.combinations(1, 15, 25, 185, 78, argnames="depth")
def test_recursion_depth(self, loader_fn, depth, limited_cache_conn):
connection = limited_cache_conn(6)
Node = self.classes.Node
for i in range(2):
stmt = (
select(Node)
.filter(Node.id == 1)
.options(loader_fn(Node.children, recursion_depth=depth))
)
with Session(connection) as s:
result = s.scalars(stmt)
self._assert_depth(result.one(), depth)
@testing.combinations(selectinload, immediateload, argnames="loader_fn")
def test_unlimited_recursion(self, loader_fn, limited_cache_conn):
connection = limited_cache_conn(6)
Node = self.classes.Node
for i in range(2):
stmt = (
select(Node)
.filter(Node.id == 1)
.options(loader_fn(Node.children, recursion_depth=-1))
)
with Session(connection) as s:
result = s.scalars(stmt)
self._assert_depth(result.one(), 200)
@testing.combinations(selectinload, immediateload, argnames="loader_fn")
@testing.combinations(4, 9, 12, 25, 41, 55, argnames="depth")
def test_warning_w_no_recursive_opt(
self, loader_fn, depth, limited_cache_conn
):
connection = limited_cache_conn(27)
Node = self.classes.Node
for i in range(2):
stmt = (
select(Node)
.filter(Node.id == 1)
.options(self._stack_loaders(loader_fn, depth))
)
# note this is a magic number, it's not important that it's exact,
# just that when someone makes a huge recursive thing,
# it warns
if depth > 8:
with expect_warnings(
"Loader depth for query is excessively deep; "
"caching will be disabled for additional loaders."
):
with Session(connection) as s:
result = s.scalars(stmt)
self._assert_depth(result.one(), depth)
else:
with Session(connection) as s:
result = s.scalars(stmt)
self._assert_depth(result.one(), depth)
# TODO:
# we should do another set of tests using Node -> Edge -> Node
|