summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndi Albrecht <albrecht.andi@gmail.com>2013-05-09 20:36:48 -0700
committerAndi Albrecht <albrecht.andi@gmail.com>2013-05-09 20:36:48 -0700
commitf14d17e2fabad1f57c77ff10573a4d8248270d96 (patch)
treedd8b1a8aabc061f9a6c90f242ce9306a68d99a9a
parent221435382e96c176f97cef0e9e5d0f0bef5a3662 (diff)
parentf38a2f367558a9fb279756d3828bad1d2e8e7f41 (diff)
downloadsqlparse-f14d17e2fabad1f57c77ff10573a4d8248270d96.tar.gz
Merge pull request #94 from kilowu/master
Fixed issue#93: Function.get_parameters returns empty list if there is only one parameter.
-rw-r--r--sqlparse/sql.py2
-rw-r--r--tests/test_parse.py5
2 files changed, 7 insertions, 0 deletions
diff --git a/sqlparse/sql.py b/sqlparse/sql.py
index 7b495a9..f8f4cc9 100644
--- a/sqlparse/sql.py
+++ b/sqlparse/sql.py
@@ -618,4 +618,6 @@ class Function(TokenList):
for t in parenthesis.tokens:
if isinstance(t, IdentifierList):
return t.get_identifiers()
+ elif isinstance(t, Identifier):
+ return [t,]
return []
diff --git a/tests/test_parse.py b/tests/test_parse.py
index 6c9cfa9..ab4e674 100644
--- a/tests/test_parse.py
+++ b/tests/test_parse.py
@@ -107,6 +107,11 @@ class SQLParseTest(TestCaseBase):
self.assertEqual(len(t), 1)
self.assert_(isinstance(t[0], sqlparse.sql.Identifier))
+ def test_function_parameter(self): # see issue94
+ t = sqlparse.parse('abs(some_col)')[0].tokens[0].get_parameters()
+ self.assertEqual(len(t), 1)
+ self.assert_(isinstance(t[0], sqlparse.sql.Identifier))
+
def test_quoted_identifier():
t = sqlparse.parse('select x.y as "z" from foo')[0].tokens