Teach filters about details and outcomes.

2 files changed, 21 insertions, 1 deletions

diff --git a/python/subunit/tests/test_subunit_filter.py b/python/subunit/tests/test_subunit_filter.py
index 9baff24..3c65ed3 100644
--- a/python/subunit/tests/test_subunit_filter.py
+++ b/python/subunit/tests/test_subunit_filter.py
@@ -91,11 +91,13 @@ class TestTestResultFilter(unittest.TestCase):
     def test_filter_predicate(self):
         """You can filter by predicate callbacks"""
         self.filtered_result = unittest.TestResult()
-        filter_cb = lambda test, err: str(err).find('error details') != -1
+        def filter_cb(test, outcome, err, details):
+            return outcome == 'success'
         self.filter = TestResultFilter(self.filtered_result,
             filter_predicate=filter_cb,
             filter_success=False)
         self.run_tests()
+        # Only success should pass
         self.assertEqual(1, self.filtered_result.testsRun)
 
     def run_tests(self):
diff --git a/python/subunit/tests/test_test_results.py b/python/subunit/tests/test_test_results.py
index cb7b47e..f0944dd 100644
--- a/python/subunit/tests/test_test_results.py
+++ b/python/subunit/tests/test_test_results.py
@@ -518,21 +518,39 @@ class TestHookedTestResultDecorator(unittest.TestCase):
     def test_addError(self):
         self.result.addError(self, subunit.RemoteError())
         
+    def test_addError_details(self):
+        self.result.addError(self, details={})
+        
     def test_addFailure(self):
         self.result.addFailure(self, subunit.RemoteError())
 
+    def test_addFailure_details(self):
+        self.result.addFailure(self, details={})
+
     def test_addSuccess(self):
         self.result.addSuccess(self)
 
+    def test_addSuccess_details(self):
+        self.result.addSuccess(self, details={})
+
     def test_addSkip(self):
         self.result.addSkip(self, "foo")
 
+    def test_addSkip_details(self):
+        self.result.addSkip(self, details={})
+
     def test_addExpectedFailure(self):
         self.result.addExpectedFailure(self, subunit.RemoteError())
 
+    def test_addExpectedFailure_details(self):
+        self.result.addExpectedFailure(self, details={})
+
     def test_addUnexpectedSuccess(self):
         self.result.addUnexpectedSuccess(self)
 
+    def test_addUnexpectedSuccess_details(self):
+        self.result.addUnexpectedSuccess(self, details={})
+
     def test_progress(self):
         self.result.progress(1, subunit.PROGRESS_SET)