summaryrefslogtreecommitdiff
path: root/python/subunit
diff options
context:
space:
mode:
authorRobert Collins <robertc@robertcollins.net>2011-05-02 11:17:36 +1200
committerRobert Collins <robertc@robertcollins.net>2011-05-02 11:17:36 +1200
commit29334d4de556ca329e89fb4a34f97c63c095b135 (patch)
tree58e3819832842f57bc9c49364ae23d45b7f412dd /python/subunit
parent098f465f5547aa75379e4e8b0b067d22fa7f34b3 (diff)
downloadsubunit-git-29334d4de556ca329e89fb4a34f97c63c095b135.tar.gz
Fix thinko in addSuccess refactoring.
Diffstat (limited to 'python/subunit')
-rw-r--r--python/subunit/__init__.py2
-rw-r--r--python/subunit/details.py5
2 files changed, 5 insertions, 2 deletions
diff --git a/python/subunit/__init__.py b/python/subunit/__init__.py
index 9d5d075..414b368 100644
--- a/python/subunit/__init__.py
+++ b/python/subunit/__init__.py
@@ -690,7 +690,7 @@ class TestProtocolClient(testresult.TestResult):
self._write_details(details)
else:
self._stream.write(_b("\n"))
- if details or error:
+ if details is not None or error is not None:
self._stream.write(self._end_simple)
def addSkip(self, test, reason=None, details=None):
diff --git a/python/subunit/details.py b/python/subunit/details.py
index 35bc88e..9e5e005 100644
--- a/python/subunit/details.py
+++ b/python/subunit/details.py
@@ -85,7 +85,10 @@ class MultipartDetailsParser(DetailsParser):
return
# TODO error handling
field, value = line[:-1].decode('utf8').split(' ', 1)
- main, sub = value.split('/')
+ try:
+ main, sub = value.split('/')
+ except ValueError:
+ raise ValueError("Invalid MIME type %r" % value)
self._content_type = content_type.ContentType(main, sub)
self._parse_state = self._get_name