diff options
author | Jens W. Klein <jk@kleinundpartner.at> | 2020-02-15 23:04:01 +0100 |
---|---|---|
committer | Jens W. Klein <jk@kleinundpartner.at> | 2020-02-15 23:25:46 +0100 |
commit | 16b4f069e6aca1ecbf804103de983ac0ec641e27 (patch) | |
tree | ade9a323173ec4bba90265e9c4ba0dcfc1c46268 | |
parent | 447121d0e41e9785251a1e7b1c7f162e4f7f00fd (diff) | |
download | zope-interface-fix-signature.tar.gz |
Fix repr of "Attribute" to look like beforefix-signature
and as usual in Python.
-rw-r--r-- | CHANGES.rst | 3 | ||||
-rw-r--r-- | src/zope/interface/interface.py | 2 | ||||
-rw-r--r-- | src/zope/interface/tests/test_interface.py | 8 |
3 files changed, 8 insertions, 5 deletions
diff --git a/CHANGES.rst b/CHANGES.rst index b21f54d..894bcbc 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -116,6 +116,9 @@ Like the above, this will break consumers depending on the exact output of error messages if more than one error is present. +- Fix repr of "Attribute" to look like before and as usual in Python. + + 4.7.1 (2019-11-11) ================== diff --git a/src/zope/interface/interface.py b/src/zope/interface/interface.py index 4ed447a..ade6f42 100644 --- a/src/zope/interface/interface.py +++ b/src/zope/interface/interface.py @@ -651,7 +651,7 @@ class Attribute(Element): return of + self.__name__ + self._get_str_info() def __repr__(self): - return "<%s.%s at 0x%x %s>" % ( + return "<%s.%s object at 0x%x %s>" % ( type(self).__module__, type(self).__name__, id(self), diff --git a/src/zope/interface/tests/test_interface.py b/src/zope/interface/tests/test_interface.py index 1ec5117..6436eca 100644 --- a/src/zope/interface/tests/test_interface.py +++ b/src/zope/interface/tests/test_interface.py @@ -1861,13 +1861,13 @@ class AttributeTests(ElementTests): method = self._makeOne() method.interface = type(self) r = repr(method) - self.assertTrue(r.startswith('<zope.interface.interface.Attribute at'), r) + self.assertTrue(r.startswith('<zope.interface.interface.Attribute object at'), r) self.assertTrue(r.endswith(' AttributeTests.TestAttribute>'), r) def test__repr__wo_interface(self): method = self._makeOne() r = repr(method) - self.assertTrue(r.startswith('<zope.interface.interface.Attribute at'), r) + self.assertTrue(r.startswith('<zope.interface.interface.Attribute object at'), r) self.assertTrue(r.endswith(' TestAttribute>'), r) def test__str__w_interface(self): @@ -1948,14 +1948,14 @@ class MethodTests(AttributeTests): method.kwargs = 'kw' method.interface = type(self) r = repr(method) - self.assertTrue(r.startswith('<zope.interface.interface.Method at'), r) + self.assertTrue(r.startswith('<zope.interface.interface.Method object at'), r) self.assertTrue(r.endswith(' MethodTests.TestMethod(**kw)>'), r) def test__repr__wo_interface(self): method = self._makeOne() method.kwargs = 'kw' r = repr(method) - self.assertTrue(r.startswith('<zope.interface.interface.Method at'), r) + self.assertTrue(r.startswith('<zope.interface.interface.Method object at'), r) self.assertTrue(r.endswith(' TestMethod(**kw)>'), r) def test__str__w_interface(self): |