diff options
| author | Jon Dufresne <jon.dufresne@gmail.com> | 2017-09-16 11:23:22 -0700 |
|---|---|---|
| committer | Jon Dufresne <jon.dufresne@gmail.com> | 2017-09-16 12:36:34 -0700 |
| commit | b1e47b43f3d2b972057ebe4c564b0ed03d39cd3d (patch) | |
| tree | cbb27e7459cdf542a021ceecde51eab2a51a36ac /pkg_resources/tests/test_pkg_resources.py | |
| parent | 9f295a706590b1e3618978d6f2d83af0b893ec4d (diff) | |
| download | python-setuptools-git-b1e47b43f3d2b972057ebe4c564b0ed03d39cd3d.tar.gz | |
Clean up resource warnings during tests
When tests are invoked with the Python flag -Wall, warnings appear in
the form of:
ResourceWarning: unclosed file ...
Close all files and resources deterministically to avoid such warnings.
Most often, easiest to do using a context manager.
Diffstat (limited to 'pkg_resources/tests/test_pkg_resources.py')
| -rw-r--r-- | pkg_resources/tests/test_pkg_resources.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/pkg_resources/tests/test_pkg_resources.py b/pkg_resources/tests/test_pkg_resources.py index 49bf7a04..c6a7ac97 100644 --- a/pkg_resources/tests/test_pkg_resources.py +++ b/pkg_resources/tests/test_pkg_resources.py @@ -92,8 +92,8 @@ class TestZipProvider(object): ts = timestamp(self.ref_time) os.utime(filename, (ts, ts)) filename = zp.get_resource_filename(manager, 'data.dat') - f = open(filename) - assert f.read() == 'hello, world!' + with open(filename) as f: + assert f.read() == 'hello, world!' manager.cleanup_resources() |