diff options
author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2023-04-05 09:27:08 +0200 |
---|---|---|
committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2023-04-05 09:50:49 +0200 |
commit | 88ef502099d535823156c31e77251dd2a723ad1c (patch) | |
tree | d38c1de13e54564277716c8f04add7ba5777f87c /examples/webenginewidgets/simplebrowser/browserwindow.cpp | |
parent | 356f65b87c508c44bf31bc3134eaebfd6f39c6ec (diff) | |
download | qtwebengine-88ef502099d535823156c31e77251dd2a723ad1c.tar.gz |
Simple browser example: Fix up the code
- Remove duplicated unused helper questionForFeature()
- Replace lambdas by slots where possible
- Fix clang warning about using multiple arguments to QString::arg()
- Remove dead code in WebView::contextMenuEvent() which checks on
inspectElement == actions.cend(), but is within an "if" checking
the same condition.
Pick-to: 6.5
Change-Id: Ie85a3811f4f5a8c3fa9550d4eb2ca5bf79e39084
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Diffstat (limited to 'examples/webenginewidgets/simplebrowser/browserwindow.cpp')
-rw-r--r-- | examples/webenginewidgets/simplebrowser/browserwindow.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/examples/webenginewidgets/simplebrowser/browserwindow.cpp b/examples/webenginewidgets/simplebrowser/browserwindow.cpp index 7a72b4a6f..7f30d2e92 100644 --- a/examples/webenginewidgets/simplebrowser/browserwindow.cpp +++ b/examples/webenginewidgets/simplebrowser/browserwindow.cpp @@ -355,9 +355,8 @@ QToolBar *BrowserWindow::createToolBar() downloadsAction->setIcon(QIcon(u":go-bottom.png"_s)); downloadsAction->setToolTip(tr("Show downloads")); navigationBar->addAction(downloadsAction); - connect(downloadsAction, &QAction::triggered, [this]() { - m_browser->downloadManagerWidget().show(); - }); + connect(downloadsAction, &QAction::triggered, + &m_browser->downloadManagerWidget(), &QWidget::show); return navigationBar; } |