diff options
| author | Michal Klocek <michal.klocek@qt.io> | 2020-08-26 16:25:00 +0200 |
|---|---|---|
| committer | Michal Klocek <michal.klocek@qt.io> | 2020-09-28 13:59:08 +0200 |
| commit | 3bf3d3fe7bcfa7933ecc2ec2f1607f586b2b00d8 (patch) | |
| tree | 85efe06d6dd9a6afb997b016007376a86c4a2aaf /src/core/api/qwebenginescript.cpp | |
| parent | b598974f9cbde2688a75488d6920e474343c84d2 (diff) | |
| download | qtwebengine-3bf3d3fe7bcfa7933ecc2ec2f1607f586b2b00d8.tar.gz | |
Cleanup qwebenginescript and qwebenginescriptcollection api
This patch cleans up script and collection apis:
* do not allocate user_script on heap, there is no need
for that.
* remove isNull(), which was used by collection.findScript(name)
* remove collection.size(), there is already collection.count()
* remove collection.findScript(name), user can use findScripts(name)
which returns list of scripts or empty list if not found
* collection.findScripts(name) is simply collection.find(name)
[ChangeLog] Removed QWebEngineScriptCollection::findScript(name),
use QWebEngineScriptCollection::find(name) instead.
Change-Id: Iecf8f1d7c26275b9ce3a1ea97cf4bd74b17f681e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'src/core/api/qwebenginescript.cpp')
| -rw-r--r-- | src/core/api/qwebenginescript.cpp | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/src/core/api/qwebenginescript.cpp b/src/core/api/qwebenginescript.cpp index e3917566a..650ad5c53 100644 --- a/src/core/api/qwebenginescript.cpp +++ b/src/core/api/qwebenginescript.cpp @@ -146,14 +146,6 @@ QWebEngineScript &QWebEngineScript::operator=(const QWebEngineScript &other) } /*! - Returns \c true is the script is null; otherwise returns \c false. -*/ -bool QWebEngineScript::isNull() const -{ - return d->isNull(); -} - -/*! * Returns the name of the script. Can be useful to retrieve a particular script from a * QWebEngineScriptCollection. * @@ -305,9 +297,6 @@ QWebEngineScript::QWebEngineScript(const UserScript &coreScript) #ifndef QT_NO_DEBUG_STREAM QDebug operator<<(QDebug d, const QWebEngineScript &script) { - if (script.isNull()) - return d.maybeSpace() << "QWebEngineScript()"; - d.nospace() << "QWebEngineScript(" << script.name() << ", "; switch (script.injectionPoint()) { case QWebEngineScript::DocumentCreation: |