summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRenata Hodovan <reni@webkit.org>2013-10-11 17:10:20 +0200
committerThe Qt Project <gerrit-noreply@qt-project.org>2013-10-11 18:51:48 +0200
commit1cb89af823e0d8186edd6a04220bc4e71c584d40 (patch)
tree53b07f7ac5bafa3edee53c9fa12e225c933eccdb
parent1841b19ff57adb8311088404e534f8707062c3b5 (diff)
downloadqtwebkit-1cb89af823e0d8186edd6a04220bc4e71c584d40.tar.gz
[Qt] SHOULD NEVER BE REACHED is touched WebCore::InputType::createStepRange
https://bugs.webkit.org/show_bug.cgi?id=121148 Non-steppable input types must not rendered as slider even if its webkit-apperance style property is set to slider-vertical/horizontal. Test: platform/qt/fast/forms/range/slider-crash-on-input.html * platform/qt/RenderThemeQStyle.cpp: (WebCore::RenderThemeQStyle::paintSliderTrack): Change-Id: I8428f62d4b0ec92f8cec0ecd0304feda5c1dc13a git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155651 268f45cc-cd09-0410-ab3c-d52691b4dbfc Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
-rw-r--r--Source/WebCore/platform/qt/RenderThemeQStyle.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/Source/WebCore/platform/qt/RenderThemeQStyle.cpp b/Source/WebCore/platform/qt/RenderThemeQStyle.cpp
index 8ba71e279..f85a75bd4 100644
--- a/Source/WebCore/platform/qt/RenderThemeQStyle.cpp
+++ b/Source/WebCore/platform/qt/RenderThemeQStyle.cpp
@@ -437,7 +437,7 @@ bool RenderThemeQStyle::paintSliderTrack(RenderObject* o, const PaintInfo& pi, c
// some styles need this to show a highlight on one side of the groove
HTMLInputElement* slider = o->node()->toInputElement();
- if (slider) {
+ if (slider && slider->isSteppable()) {
p.styleOption.slider.upsideDown = (p.appearance == SliderHorizontalPart) && !o->style()->isLeftToRightDirection();
// Use the width as a multiplier in case the slider values are <= 1
const int width = r.width() > 0 ? r.width() : 100;