summaryrefslogtreecommitdiff
path: root/Source/JavaScriptCore/API/OpaqueJSString.cpp
diff options
context:
space:
mode:
authorSimon Hausmann <simon.hausmann@digia.com>2012-10-17 16:21:14 +0200
committerSimon Hausmann <simon.hausmann@digia.com>2012-10-17 16:21:14 +0200
commit8995b83bcbfbb68245f779b64e5517627c6cc6ea (patch)
tree17985605dab9263cc2444bd4d45f189e142cca7c /Source/JavaScriptCore/API/OpaqueJSString.cpp
parentb9c9652036d5e9f1e29c574f40bc73a35c81ace6 (diff)
downloadqtwebkit-8995b83bcbfbb68245f779b64e5517627c6cc6ea.tar.gz
Imported WebKit commit cf4f8fc6f19b0629f51860cb2d4b25e139d07e00 (http://svn.webkit.org/repository/webkit/trunk@131592)
New snapshot that includes the build fixes for Mac OS X 10.6 and earlier as well as the previously cherry-picked changes
Diffstat (limited to 'Source/JavaScriptCore/API/OpaqueJSString.cpp')
-rw-r--r--Source/JavaScriptCore/API/OpaqueJSString.cpp17
1 files changed, 11 insertions, 6 deletions
diff --git a/Source/JavaScriptCore/API/OpaqueJSString.cpp b/Source/JavaScriptCore/API/OpaqueJSString.cpp
index 457cb27f7..ac7cfd16a 100644
--- a/Source/JavaScriptCore/API/OpaqueJSString.cpp
+++ b/Source/JavaScriptCore/API/OpaqueJSString.cpp
@@ -35,21 +35,26 @@ using namespace JSC;
PassRefPtr<OpaqueJSString> OpaqueJSString::create(const String& string)
{
if (!string.isNull())
- return adoptRef(new OpaqueJSString(string.characters(), string.length()));
+ return adoptRef(new OpaqueJSString(string));
return 0;
}
String OpaqueJSString::string() const
{
- if (this && m_characters)
- return String(m_characters, m_length);
- return String();
+ if (!this)
+ return String();
+
+ // Return a copy of the wrapped string, because the caller may make it an Identifier.
+ return m_string.isolatedCopy();
}
Identifier OpaqueJSString::identifier(JSGlobalData* globalData) const
{
- if (!this || !m_characters)
+ if (!this || !m_string.length())
return Identifier(globalData, static_cast<const char*>(0));
- return Identifier(globalData, m_characters, m_length);
+ if (m_string.is8Bit())
+ return Identifier(globalData, m_string.characters8(), m_string.length());
+
+ return Identifier(globalData, m_string.characters16(), m_string.length());
}