diff options
| author | Jocelyn Turcotte <jocelyn.turcotte@digia.com> | 2013-01-28 10:33:23 +0100 |
|---|---|---|
| committer | The Qt Project <gerrit-noreply@qt-project.org> | 2013-01-28 15:52:38 +0100 |
| commit | d65f551ec3dd28be38d75a893f74919dfa27071e (patch) | |
| tree | 877051dae44a10ce489d5b122d2085b0cd3d828f /Source/JavaScriptCore/runtime/JSObject.cpp | |
| parent | 81cb91bb6b34f10cb4f1e8da9a0dccc6a9b4a2c4 (diff) | |
| download | qtwebkit-d65f551ec3dd28be38d75a893f74919dfa27071e.tar.gz | |
[Qt] Fix a crash when the QQuickWebPage is destroyed between the scene graph sync and render.
https://bugs.webkit.org/show_bug.cgi?id=106018
Reviewed by Simon Hausmann.
The main and rendering threads are only guaranteed to be synchronised in
the updatePaintNode call. In every other cases, QQuickItems cannot be
safely accessed from the rendering thread.
Do as the first patch version in
https://bugs.webkit.org/show_bug.cgi?id=104574 was doing and copy the
ratio value directly to fix the issue.
Also add a note about the threading issue in QQuickWebPage::updatePaintNode.
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPage::updatePaintNode):
* UIProcess/qt/QtWebPageSGNode.cpp:
(WebKit::QtWebPageSGNode::QtWebPageSGNode):
* UIProcess/qt/QtWebPageSGNode.h:
(QtWebPageSGNode):
(WebKit::QtWebPageSGNode::devicePixelRatio):
(WebKit::QtWebPageSGNode::setDevicePixelRatio):
Change-Id: I2ef35f357c56c251033573d4435ddd7768a4422f
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
Diffstat (limited to 'Source/JavaScriptCore/runtime/JSObject.cpp')
0 files changed, 0 insertions, 0 deletions