diff options
Diffstat (limited to 'Source/JavaScriptCore/runtime/PropertyTable.cpp')
-rw-r--r-- | Source/JavaScriptCore/runtime/PropertyTable.cpp | 45 |
1 files changed, 16 insertions, 29 deletions
diff --git a/Source/JavaScriptCore/runtime/PropertyTable.cpp b/Source/JavaScriptCore/runtime/PropertyTable.cpp index bb5ecce4a..74474c6d9 100644 --- a/Source/JavaScriptCore/runtime/PropertyTable.cpp +++ b/Source/JavaScriptCore/runtime/PropertyTable.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2013 Apple Inc. All rights reserved. + * Copyright (C) 2013, 2014 Apple Inc. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -10,10 +10,10 @@ * notice, this list of conditions and the following disclaimer in the * documentation and/or other materials provided with the distribution. * - * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY + * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR - * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR @@ -31,9 +31,11 @@ #include "SlotVisitorInlines.h" #include "StructureInlines.h" +#include <wtf/CryptographicallyRandomNumber.h> + namespace JSC { -const ClassInfo PropertyTable::s_info = { "PropertyTable", 0, 0, 0, CREATE_METHOD_TABLE(PropertyTable) }; +const ClassInfo PropertyTable::s_info = { "PropertyTable", 0, 0, CREATE_METHOD_TABLE(PropertyTable) }; PropertyTable* PropertyTable::create(VM& vm, unsigned initialCapacity) { @@ -42,16 +44,16 @@ PropertyTable* PropertyTable::create(VM& vm, unsigned initialCapacity) return table; } -PropertyTable* PropertyTable::clone(VM& vm, JSCell* owner, const PropertyTable& other) +PropertyTable* PropertyTable::clone(VM& vm, const PropertyTable& other) { - PropertyTable* table = new (NotNull, allocateCell<PropertyTable>(vm.heap)) PropertyTable(vm, owner, other); + PropertyTable* table = new (NotNull, allocateCell<PropertyTable>(vm.heap)) PropertyTable(vm, other); table->finishCreation(vm); return table; } -PropertyTable* PropertyTable::clone(VM& vm, JSCell* owner, unsigned initialCapacity, const PropertyTable& other) +PropertyTable* PropertyTable::clone(VM& vm, unsigned initialCapacity, const PropertyTable& other) { - PropertyTable* table = new (NotNull, allocateCell<PropertyTable>(vm.heap)) PropertyTable(vm, owner, initialCapacity, other); + PropertyTable* table = new (NotNull, allocateCell<PropertyTable>(vm.heap)) PropertyTable(vm, initialCapacity, other); table->finishCreation(vm); return table; } @@ -67,7 +69,7 @@ PropertyTable::PropertyTable(VM& vm, unsigned initialCapacity) ASSERT(isPowerOf2(m_indexSize)); } -PropertyTable::PropertyTable(VM& vm, JSCell* owner, const PropertyTable& other) +PropertyTable::PropertyTable(VM& vm, const PropertyTable& other) : JSCell(vm, vm.propertyTableStructure.get()) , m_indexSize(other.m_indexSize) , m_indexMask(other.m_indexMask) @@ -80,18 +82,16 @@ PropertyTable::PropertyTable(VM& vm, JSCell* owner, const PropertyTable& other) memcpy(m_index, other.m_index, dataSize()); iterator end = this->end(); - for (iterator iter = begin(); iter != end; ++iter) { + for (iterator iter = begin(); iter != end; ++iter) iter->key->ref(); - Heap::writeBarrier(owner, iter->specificValue.get()); - } // Copy the m_deletedOffsets vector. Vector<PropertyOffset>* otherDeletedOffsets = other.m_deletedOffsets.get(); if (otherDeletedOffsets) - m_deletedOffsets = adoptPtr(new Vector<PropertyOffset>(*otherDeletedOffsets)); + m_deletedOffsets = std::make_unique<Vector<PropertyOffset>>(*otherDeletedOffsets); } -PropertyTable::PropertyTable(VM& vm, JSCell* owner, unsigned initialCapacity, const PropertyTable& other) +PropertyTable::PropertyTable(VM& vm, unsigned initialCapacity, const PropertyTable& other) : JSCell(vm, vm.propertyTableStructure.get()) , m_indexSize(sizeForCapacity(initialCapacity)) , m_indexMask(m_indexSize - 1) @@ -107,13 +107,12 @@ PropertyTable::PropertyTable(VM& vm, JSCell* owner, unsigned initialCapacity, co ASSERT(canInsert()); reinsert(*iter); iter->key->ref(); - Heap::writeBarrier(owner, iter->specificValue.get()); } // Copy the m_deletedOffsets vector. Vector<PropertyOffset>* otherDeletedOffsets = other.m_deletedOffsets.get(); if (otherDeletedOffsets) - m_deletedOffsets = adoptPtr(new Vector<PropertyOffset>(*otherDeletedOffsets)); + m_deletedOffsets = std::make_unique<Vector<PropertyOffset>>(*otherDeletedOffsets); } void PropertyTable::destroy(JSCell* cell) @@ -130,17 +129,5 @@ PropertyTable::~PropertyTable() fastFree(m_index); } -void PropertyTable::visitChildren(JSCell* cell, SlotVisitor& visitor) -{ - PropertyTable* thisObject = jsCast<PropertyTable*>(cell); - ASSERT_GC_OBJECT_INHERITS(thisObject, &s_info); - ASSERT(thisObject->structure()->typeInfo().overridesVisitChildren()); - - JSCell::visitChildren(thisObject, visitor); - - PropertyTable::iterator end = thisObject->end(); - for (PropertyTable::iterator ptr = thisObject->begin(); ptr != end; ++ptr) - visitor.append(&ptr->specificValue); -} +} // namespace JSC -} |