diff options
Diffstat (limited to 'Tools/Scripts/webkitpy/common/config/committers.py')
| -rw-r--r-- | Tools/Scripts/webkitpy/common/config/committers.py | 560 |
1 files changed, 54 insertions, 506 deletions
diff --git a/Tools/Scripts/webkitpy/common/config/committers.py b/Tools/Scripts/webkitpy/common/config/committers.py index e49eebf52..62a09329e 100644 --- a/Tools/Scripts/webkitpy/common/config/committers.py +++ b/Tools/Scripts/webkitpy/common/config/committers.py @@ -29,9 +29,18 @@ # # WebKit's Python module for committer and reviewer validation. +import fnmatch +import json + from webkitpy.common.editdistance import edit_distance +from webkitpy.common.memoized import memoized +from webkitpy.common.system.filesystem import FileSystem + + +# The list of contributors have been moved to contributors.json -class Account(object): + +class Contributor(object): def __init__(self, name, email_or_emails, irc_nickname_or_nicknames=None): assert(name) assert(email_or_emails) @@ -54,6 +63,9 @@ class Account(object): return self.emails[0] def __str__(self): + return unicode(self).encode('utf-8') + + def __unicode__(self): return '"%s" <%s>' % (self.full_name, self.emails[0]) def contains_string(self, search_string): @@ -69,11 +81,17 @@ class Account(object): return True return False - -class Contributor(Account): - def __init__(self, name, email_or_emails, irc_nickname=None): - Account.__init__(self, name, email_or_emails, irc_nickname) - self.is_contributor = True + def matches_glob(self, glob_string): + if fnmatch.fnmatch(self.full_name, glob_string): + return True + if self.irc_nicknames: + for nickname in self.irc_nicknames: + if fnmatch.fnmatch(nickname, glob_string): + return True + for email in self.emails: + if fnmatch.fnmatch(email, glob_string): + return True + return False class Committer(Contributor): @@ -88,490 +106,20 @@ class Reviewer(Committer): self.can_review = True -# This is a list of email addresses that have bugzilla accounts but are not -# used for contributing (such as mailing lists). - - -watchers_who_are_not_contributors = [ - Account("Chromium Compositor Bugs", ["cc-bugs@chromium.org"], ""), - Account("Chromium Media Reviews", ["feature-media-reviews@chromium.org"], ""), - Account("David Levin", ["levin+threading@chromium.org"], ""), - Account("David Levin", ["levin+watchlist@chromium.org"], ""), - Account("Kent Tamura", ["tkent+wkapi@chromium.org"], ""), -] - - -# This is a list of people (or bots) who are neither committers nor reviewers, but get -# frequently CC'ed by others on Bugzilla bugs, so their names should be -# supported by autocomplete. No review needed to add to the list. - - -contributors_who_are_not_committers = [ - Contributor("Adobe Bug Tracker", "WebkitBugTracker@adobe.com"), - Contributor("Aharon Lanin", "aharon@google.com"), - Contributor("Alan Stearns", "stearns@adobe.com", "astearns"), - Contributor("Alejandro Pineiro", "apinheiro@igalia.com"), - Contributor("Alexey Marinichev", ["amarinichev@chromium.org", "amarinichev@google.com"], "amarinichev"), - Contributor("Andras Piroska", "pandras@inf.u-szeged.hu", "andris88"), - Contributor("Andrei Bucur", "abucur@adobe.com", "abucur"), - Contributor("Anne van Kesteren", "annevankesteren+webkit@gmail.com", "annevk"), - Contributor("Annie Sullivan", "sullivan@chromium.org", "annie"), - Contributor("Aryeh Gregor", "ayg@aryeh.name", "AryehGregor"), - Contributor("Balazs Ankes", "bank@inf.u-szeged.hu", "abalazs"), - Contributor("Brian Salomon", "bsalomon@google.com"), - Contributor("Commit Queue", "commit-queue@webkit.org"), - Contributor("Daniel Sievers", "sievers@chromium.org"), - Contributor("David Dorwin", "ddorwin@chromium.org", "ddorwin"), - Contributor("David Reveman", "reveman@chromium.org", "reveman"), - Contributor("Dongsung Huang", "luxtella@company100.net", "Huang"), - Contributor("Douglas Davidson", "ddavidso@apple.com"), - Contributor("Edward O'Connor", "eoconnor@apple.com", "hober"), - Contributor("Elliott Sprehn", "esprehn@chromium.org", "esprehn"), - Contributor("Eric Penner", "epenner@chromium.org", "epenner"), - Contributor("Felician Marton", ["felician@inf.u-szeged.hu", "marton.felician.zoltan@stud.u-szeged.hu"], "Felician"), - Contributor("Finnur Thorarinsson", ["finnur@chromium.org", "finnur.webkit@gmail.com"], "finnur"), - Contributor("Forms Bugs", "forms-bugs@chromium.org"), - Contributor("Glenn Adams", "glenn@skynav.com", "gasubic"), - Contributor("Gabor Ballabas", "gaborb@inf.u-szeged.hu", "bgabor"), - Contributor("Grace Kloba", "klobag@chromium.org", "klobag"), - Contributor("Greg Simon", "gregsimon@chromium.org", "gregsimon"), - Contributor("Gregg Tavares", ["gman@google.com", "gman@chromium.org"], "gman"), - Contributor("Hao Zheng", "zhenghao@chromium.org"), - Contributor("Harald Alvestrand", "hta@google.com", "hta"), - Contributor("Ian Hickson", "ian@hixie.ch", "hixie"), - Contributor("Janos Badics", "jbadics@inf.u-szeged.hu", "dicska"), - Contributor("Jonathan Backer", "backer@chromium.org", "backer"), - Contributor("Jeff Timanus", ["twiz@chromium.org", "twiz@google.com"], "twiz"), - Contributor("Jing Zhao", "jingzhao@chromium.org"), - Contributor("Joanmarie Diggs", "jdiggs@igalia.com"), - Contributor("John Bates", ["jbates@google.com", "jbates@chromium.org"], "jbates"), - Contributor("John Bauman", ["jbauman@chromium.org", "jbauman@google.com"], "jbauman"), - Contributor("John Mellor", "johnme@chromium.org", "johnme"), - Contributor("Kulanthaivel Palanichamy", "kulanthaivel@codeaurora.org", "kvel"), - Contributor("Kiran Muppala", "cmuppala@apple.com", "kiranm"), - Contributor("Mihai Balan", "mibalan@adobe.com", "miChou"), - Contributor("Min Qin", "qinmin@chromium.org"), - Contributor("Nandor Huszka", "hnandor@inf.u-szeged.hu", "hnandor"), - Contributor("Oliver Varga", ["voliver@inf.u-szeged.hu", "Varga.Oliver@stud.u-szeged.hu"], "TwistO"), - Contributor("Peter Gal", "galpeter@inf.u-szeged.hu", "elecro"), - Contributor("Peter Linss", "peter.linss@hp.com", "plinss"), - Contributor("Pravin D", "pravind.2k4@gmail.com", "pravind"), - Contributor("Radar WebKit Bug Importer", "webkit-bug-importer@group.apple.com"), - Contributor("Raul Hudea", "rhudea@adobe.com", "rhudea"), - Contributor("Roland Takacs", "rtakacs@inf.u-szeged.hu", "rtakacs"), - Contributor(u"Sami Ky\u00f6stil\u00e4", "skyostil@chromium.org", "skyostil"), - Contributor("Szilard Ledan-Muntean", "szledan@inf.u-szeged.hu", "szledan"), - Contributor("Tab Atkins", ["tabatkins@google.com", "jackalmage@gmail.com"], "tabatkins"), - Contributor("Tamas Czene", ["tczene@inf.u-szeged.hu", "Czene.Tamas@stud.u-szeged.hu"], "tczene"), - Contributor("Tien-Ren Chen", "trchen@chromium.org", "trchen"), - Contributor("WebKit Review Bot", "webkit.review.bot@gmail.com", "sheriff-bot"), - Contributor("Web Components Team", "webcomponents-bugzilla@chromium.org"), - Contributor("Wyatt Carss", ["wcarss@chromium.org", "wcarss@google.com"], "wcarss"), - Contributor("Zeev Lieber", "zlieber@chromium.org"), - Contributor("Zoltan Arvai", "zarvai@inf.u-szeged.hu", "azbest_hu"), - Contributor("Zsolt Feher", "feherzs@inf.u-szeged.hu", "Smith"), -] - - -# This is intended as a canonical, machine-readable list of all non-reviewer -# committers for WebKit. If your name is missing here and you are a committer, -# please add it. No review needed. All reviewers are committers, so this list -# is only of committers who are not reviewers. - - -committers_unable_to_review = [ - Committer("Aaron Boodman", "aa@chromium.org", "aboodman"), - Committer("Adam Bergkvist", "adam.bergkvist@ericsson.com", "adambe"), - Committer("Adam Kallai", "kadam@inf.u-szeged.hu", "kadam"), - Committer("Adam Klein", "adamk@chromium.org", "aklein"), - Committer("Adam Langley", "agl@chromium.org", "agl"), - Committer("Ademar de Souza Reis Jr", ["ademar.reis@gmail.com", "ademar@webkit.org"], "ademar"), - Committer("Albert J. Wong", "ajwong@chromium.org"), - Committer("Alec Flett", ["alecflett@chromium.org", "alecflett@google.com"], "alecf"), - Committer(u"Alexander F\u00e6r\u00f8y", ["ahf@0x90.dk", "alexander.faeroy@nokia.com"], "ahf"), - Committer("Alexander Kellett", ["lypanov@mac.com", "a-lists001@lypanov.net", "lypanov@kde.org"], "lypanov"), - Committer("Alexandre Elias", ["aelias@chromium.org", "aelias@google.com"], "aelias"), - Committer("Alexandru Chiculita", "achicu@adobe.com", "achicu"), - Committer("Alice Boxhall", "aboxhall@chromium.org", "aboxhall"), - Committer("Allan Sandfeld Jensen", ["allan.jensen@digia.com", "kde@carewolf.com", "sandfeld@kde.org", "allan.jensen@nokia.com"], "carewolf"), - Committer("Alok Priyadarshi", "alokp@chromium.org", "alokp"), - Committer("Ami Fischman", ["fischman@chromium.org", "fischman@google.com"], "fischman"), - Committer("Amruth Raj", "amruthraj@motorola.com", "amruthraj"), - Committer("Andre Boule", "aboule@apple.com"), - Committer("Andrei Popescu", "andreip@google.com", "andreip"), - Committer("Andrew Wellington", ["andrew@webkit.org", "proton@wiretapped.net"], "proton"), - Committer("Andrew Scherkus", "scherkus@chromium.org", "scherkus"), - Committer("Andrey Adaykin", "aandrey@chromium.org", "aandrey"), - Committer("Andrey Kosyakov", "caseq@chromium.org", "caseq"), - Committer("Andras Becsi", ["abecsi@webkit.org", "andras.becsi@digia.com"], "bbandix"), - Committer("Andy Wingo", "wingo@igalia.com", "wingo"), - Committer("Anna Cavender", "annacc@chromium.org", "annacc"), - Committer("Anthony Ricaud", "rik@webkit.org", "rik"), - Committer("Antoine Labour", "piman@chromium.org", "piman"), - Committer("Anton D'Auria", "adauria@apple.com", "antonlefou"), - Committer("Anton Muhin", "antonm@chromium.org", "antonm"), - Committer("Arko Saha", "arko@motorola.com", "arkos"), - Committer("Arvid Nilsson", "anilsson@rim.com", "anilsson"), - Committer("Balazs Kelemen", "kbalazs@webkit.org", "kbalazs"), - Committer("Ben Murdoch", "benm@google.com", "benm"), - Committer("Ben Wells", "benwells@chromium.org", "benwells"), - Committer("Benjamin C Meyer", ["ben@meyerhome.net", "ben@webkit.org", "bmeyer@rim.com"], "icefox"), - Committer("Benjamin Kalman", ["kalman@chromium.org", "kalman@google.com"], "kalman"), - Committer("Benjamin Otte", ["otte@gnome.org", "otte@webkit.org"], "otte"), - Committer("Bill Budge", ["bbudge@chromium.org", "bbudge@gmail.com"], "bbudge"), - Committer("Brett Wilson", "brettw@chromium.org", "brettx"), - Committer("Bruno de Oliveira Abinader", ["bruno.abinader@basyskom.com", "brunoabinader@gmail.com"], "abinader"), - Committer("Cameron McCormack", ["cam@mcc.id.au", "cam@webkit.org"], "heycam"), - Committer("Carol Szabo", ["carol@webkit.org", "carol.szabo@nokia.com"], "cszabo1"), - Committer("Cary Clark", ["caryclark@google.com", "caryclark@chromium.org"], "caryclark"), - Committer("Charles Reis", "creis@chromium.org", "creis"), - Committer("Charles Wei", ["charles.wei@torchmobile.com.cn"], "cswei"), - Committer("Chris Evans", ["cevans@google.com", "cevans@chromium.org"]), - Committer("Chris Guillory", ["ctguil@chromium.org", "chris.guillory@google.com"], "ctguil"), - Committer("Chris Petersen", "cpetersen@apple.com", "cpetersen"), - Committer("Christian Dywan", ["christian@twotoasts.de", "christian@webkit.org", "christian@lanedo.com"]), - Committer("Christophe Dumez", ["christophe.dumez@intel.com", "dchris@gmail.com"], "chris-qBT"), - Committer("Collin Jackson", "collinj@webkit.org", "collinjackson"), - Committer("Cris Neckar", "cdn@chromium.org", "cneckar"), - Committer("Dan Winship", "danw@gnome.org", "danw"), - Committer("Dana Jansens", "danakj@chromium.org", "danakj"), - Committer("Daniel Cheng", "dcheng@chromium.org", "dcheng"), - Committer("Dave Barton", "dbarton@mathscribe.com", "davebarton"), - Committer("Dave Tharp", "dtharp@codeaurora.org", "dtharp"), - Committer("David Michael Barr", ["davidbarr@chromium.org", "davidbarr@google.com", "b@rr-dav.id.au"], "barrbrain"), - Committer("David Grogan", ["dgrogan@chromium.org", "dgrogan@google.com"], "dgrogan"), - Committer("David Smith", ["catfish.man@gmail.com", "dsmith@webkit.org"], "catfishman"), - Committer("Diego Gonzalez", ["diegohcg@webkit.org", "diego.gonzalez@openbossa.org"], "diegohcg"), - Committer("Dinu Jacob", "dinu.s.jacob@intel.com", "dsjacob"), - Committer("Dmitry Lomov", ["dslomov@google.com", "dslomov@chromium.org"], "dslomov"), - Committer("Dominic Cooney", ["dominicc@chromium.org", "dominicc@google.com"], "dominicc"), - Committer("Dominic Mazzoni", ["dmazzoni@google.com", "dmazzoni@chromium.org"], "dmazzoni"), - Committer(u"Dominik R\u00f6ttsches", ["dominik.rottsches@intel.com", "d-r@roettsches.de"], "drott"), - Committer("Drew Wilson", "atwilson@chromium.org", "atwilson"), - Committer("Eli Fidler", ["eli@staikos.net", "efidler@rim.com"], "efidler"), - Committer("Elliot Poger", "epoger@chromium.org", "epoger"), - Committer("Erik Arvidsson", "arv@chromium.org", "arv"), - Committer("Eric Roman", "eroman@chromium.org", "eroman"), - Committer("Eric Uhrhane", "ericu@chromium.org", "ericu"), - Committer("Evan Martin", "evan@chromium.org", "evmar"), - Committer("Evan Stade", "estade@chromium.org", "estade"), - Committer("Fady Samuel", "fsamuel@chromium.org", "fsamuel"), - Committer("Feng Qian", "feng@chromium.org"), - Committer("Florin Malita", ["fmalita@chromium.org", "fmalita@google.com"], "fmalita"), - Committer("Fumitoshi Ukai", "ukai@chromium.org", "ukai"), - Committer("Gabor Loki", "loki@webkit.org", "loki04"), - Committer("Gabor Rapcsanyi", ["rgabor@webkit.org", "rgabor@inf.u-szeged.hu"], "rgabor"), - Committer("Gavin Peters", ["gavinp@chromium.org", "gavinp@webkit.org", "gavinp@google.com"], "gavinp"), - Committer("Girish Ramakrishnan", ["girish@forwardbias.in", "ramakrishnan.girish@gmail.com"], "girishr"), - Committer("Graham Dennis", ["Graham.Dennis@gmail.com", "gdennis@webkit.org"]), - Committer("Greg Bolsinga", "bolsinga@apple.com"), - Committer("Grzegorz Czajkowski", "g.czajkowski@samsung.com", "grzegorz"), - Committer("Hans Wennborg", "hans@chromium.org", "hwennborg"), - Committer("Hayato Ito", "hayato@chromium.org", "hayato"), - Committer("Hironori Bono", "hbono@chromium.org", "hbono"), - Committer("Helder Correia", "helder.correia@nokia.com", "helder"), - Committer("Hin-Chung Lam", ["hclam@google.com", "hclam@chromium.org"]), - Committer("Hugo Parente Lima", "hugo.lima@openbossa.org", "hugopl"), - Committer("Ian Vollick", "vollick@chromium.org", "vollick"), - Committer("Igor Trindade Oliveira", ["igor.oliveira@webkit.org", "igor.o@sisa.samsung.com"], "igoroliveira"), - Committer("Ilya Sherman", "isherman@chromium.org", "isherman"), - Committer("Ilya Tikhonovsky", "loislo@chromium.org", "loislo"), - Committer("Ivan Krsti\u0107", "ike@apple.com"), - Committer("Jacky Jiang", ["jkjiang@webkit.org", "zkjiang008@gmail.com", "zhajiang@rim.com"], "jkjiang"), - Committer("Jakob Petsovits", ["jpetsovits@rim.com", "jpetso@gmx.at"], "jpetso"), - Committer("Jakub Wieczorek", "jwieczorek@webkit.org", "fawek"), - Committer("James Hawkins", ["jhawkins@chromium.org", "jhawkins@google.com"], "jhawkins"), - Committer("James Kozianski", ["koz@chromium.org", "koz@google.com"], "koz"), - Committer("James Simonsen", "simonjam@chromium.org", "simonjam"), - Committer("Jarred Nicholls", ["jarred@webkit.org", "jarred@sencha.com"], "jarrednicholls"), - Committer("Jason Liu", ["jason.liu@torchmobile.com.cn", "jasonliuwebkit@gmail.com"], "jasonliu"), - Committer("Jay Civelli", "jcivelli@chromium.org", "jcivelli"), - Committer("Jeff Miller", "jeffm@apple.com", "jeffm7"), - Committer("Jeffrey Pfau", ["jeffrey@endrift.com", "jpfau@apple.com"], "jpfau"), - Committer("Jenn Braithwaite", "jennb@chromium.org", "jennb"), - Committer("Jens Alfke", ["snej@chromium.org", "jens@apple.com"]), - Committer("Jer Noble", "jer.noble@apple.com", "jernoble"), - Committer("Jeremy Moskovich", ["playmobil@google.com", "jeremy@chromium.org"], "jeremymos"), - Committer("Jesus Sanchez-Palencia", ["jesus@webkit.org", "jesus.palencia@openbossa.org"], "jeez_"), - Committer("Jia Pu", "jpu@apple.com"), - Committer("Joe Thomas", "joethomas@motorola.com", "joethomas"), - Committer("John Abd-El-Malek", "jam@chromium.org", "jam"), - Committer("John Gregg", ["johnnyg@google.com", "johnnyg@chromium.org"], "johnnyg"), - Committer("John Knottenbelt", "jknotten@chromium.org", "jknotten"), - Committer("Johnny Ding", ["jnd@chromium.org", "johnnyding.webkit@gmail.com"], "johnnyding"), - Committer("Jon Lee", "jonlee@apple.com", "jonlee"), - Committer("Jonathan Dong", ["jonathan.dong@torchmobile.com.cn"], "jondong"), - Committer("Joone Hur", ["joone@webkit.org", "joone.hur@intel.com"], "joone"), - Committer("Joost de Valk", ["joost@webkit.org", "webkit-dev@joostdevalk.nl"], "Altha"), - Committer("Joshua Bell", ["jsbell@chromium.org", "jsbell@google.com"], "jsbell"), - Committer("Julie Parent", ["jparent@google.com", "jparent@chromium.org"], "jparent"), - Committer("Jungshik Shin", "jshin@chromium.org"), - Committer("Justin Novosad", ["junov@google.com", "junov@chromium.org"], "junov"), - Committer("Justin Schuh", "jschuh@chromium.org", "jschuh"), - Committer("Kaustubh Atrawalkar", ["kaustubh@motorola.com"], "silverroots"), - Committer("Keishi Hattori", "keishi@webkit.org", "keishi"), - Committer("Kelly Norton", "knorton@alum.mit.edu"), - Committer("Ken Buchanan", "kenrb@chromium.org", "kenrb"), - Committer("Kenichi Ishibashi", "bashi@chromium.org", "bashi"), - Committer("Kenji Imasaki", "imasaki@chromium.org", "imasaki"), - Committer("Kent Hansen", "kent.hansen@nokia.com", "khansen"), - Committer("Kihong Kwon", "kihong.kwon@samsung.com", "kihong"), - Committer(u"Kim Gr\u00f6nholm", "kim.1.gronholm@nokia.com"), - Committer("Kimmo Kinnunen", ["kimmo.t.kinnunen@nokia.com", "kimmok@iki.fi", "ktkinnun@webkit.org"], "kimmok"), - Committer("Kinuko Yasuda", "kinuko@chromium.org", "kinuko"), - Committer("Konrad Piascik", "kpiascik@rim.com", "kpiascik"), - Committer("Kristof Kosztyo", "kkristof@inf.u-szeged.hu", "kkristof"), - Committer("Krzysztof Kowalczyk", "kkowalczyk@gmail.com"), - Committer("Kwang Yul Seo", ["skyul@company100.net", "kseo@webkit.org"], "kseo"), - Committer("Lauro Neto", "lauro.neto@openbossa.org", "lmoura"), - Committer("Leandro Gracia Gil", "leandrogracia@chromium.org", "leandrogracia"), - Committer("Leandro Pereira", ["leandro@profusion.mobi", "leandro@webkit.org"], "acidx"), - Committer("Leo Yang", ["leoyang@rim.com", "leoyang@webkit.org", "leoyang.webkit@gmail.com"], "leoyang"), - Committer("Li Yin", ["li.yin@intel.com"], "liyin"), - Committer("Lucas De Marchi", ["demarchi@webkit.org", "lucas.demarchi@profusion.mobi"], "demarchi"), - Committer("Lucas Forschler", ["lforschler@apple.com"], "lforschler"), - Committer("Luciano Wolf", "luciano.wolf@openbossa.org", "luck"), - Committer("Luke Macpherson", ["macpherson@chromium.org", "macpherson@google.com"], "macpherson"), - Committer("Mads Ager", "ager@chromium.org"), - Committer("Mahesh Kulkarni", ["mahesh.kulkarni@nokia.com", "maheshk@webkit.org"], "maheshk"), - Committer("Marcus Voltis Bulach", "bulach@chromium.org"), - Committer("Mario Sanchez Prada", ["mario@webkit.org"], "msanchez"), - Committer("Mark Lam", "mark.lam@apple.com", "mlam"), - Committer("Mary Wu", ["mary.wu@torchmobile.com.cn", "wwendy2007@gmail.com"], "marywu"), - Committer("Matt Delaney", "mdelaney@apple.com"), - Committer("Matt Falkenhagen", "falken@chromium.org", "falken"), - Committer("Matt Lilek", ["mlilek@apple.com", "webkit@mattlilek.com", "pewtermoose@webkit.org"], "pewtermoose"), - Committer("Matt Perry", "mpcomplete@chromium.org"), - Committer("Maxime Britto", ["maxime.britto@gmail.com", "britto@apple.com"]), - Committer("Maxime Simon", ["simon.maxime@gmail.com", "maxime.simon@webkit.org"], "maxime.simon"), - Committer(u"Michael Br\u00fcning", ["michaelbruening@gmail.com", "michael.bruning@digia.com", "michael.bruning@nokia.com"], "mibrunin"), - Committer("Michael Nordman", "michaeln@google.com", "michaeln"), - Committer("Michelangelo De Simone", "michelangelo@webkit.org", "michelangelo"), - Committer("Mihnea Ovidenie", "mihnea@adobe.com", "mihnea"), - Committer("Mike Belshe", ["mbelshe@chromium.org", "mike@belshe.com"]), - Committer("Mike Fenton", ["mifenton@rim.com", "mike.fenton@torchmobile.com"], "mfenton"), - Committer("Mike Lawther", "mikelawther@chromium.org", "mikelawther"), - Committer("Mike Reed", "reed@google.com", "reed"), - Committer("Mike Thole", ["mthole@mikethole.com", "mthole@apple.com"]), - Committer("Mike West", ["mkwst@chromium.org", "mike@mikewest.org"], "mkwst"), - Committer("Mikhail Naganov", "mnaganov@chromium.org"), - Committer("Naoki Takano", ["honten@chromium.org", "takano.naoki@gmail.com"], "honten"), - Committer("Nat Duca", ["nduca@chromium.org", "nduca@google.com"], "nduca"), - Committer("Nayan Kumar K", ["nayankk@motorola.com", "nayankk@gmail.com"], "xc0ffee"), - Committer("Nico Weber", ["thakis@chromium.org", "thakis@google.com"], "thakis"), - Committer("Nima Ghanavatian", ["nghanavatian@rim.com", "nima.ghanavatian@gmail.com"], "nghanavatian"), - Committer("Noel Gordon", ["noel.gordon@gmail.com", "noel@chromium.org", "noel@google.com"], "noel"), - Committer("Pam Greene", "pam@chromium.org", "pamg"), - Committer("Patrick Gansterer", ["paroga@paroga.com", "paroga@webkit.org"], "paroga"), - Committer("Pavel Podivilov", "podivilov@chromium.org", "podivilov"), - Committer("Peter Beverloo", ["peter@chromium.org", "peter@webkit.org", "beverloo@google.com"], "beverloo"), - Committer("Peter Kasting", ["pkasting@google.com", "pkasting@chromium.org"], "pkasting"), - Committer("Peter Varga", ["pvarga@webkit.org", "pvarga@inf.u-szeged.hu"], "stampho"), - Committer("Philip Rogers", ["pdr@google.com", "pdr@chromium.org"], "pdr"), - Committer("Pierre d'Herbemont", ["pdherbemont@free.fr", "pdherbemont@apple.com"], "pdherbemont"), - Committer("Pierre-Olivier Latour", "pol@apple.com", "pol"), - Committer("Pierre Rossi", "pierre.rossi@gmail.com", "elproxy"), - Committer("Pratik Solanki", "psolanki@apple.com", "psolanki"), - Committer("Qi Zhang", "qi.zhang02180@gmail.com", "qi"), - Committer("Rafael Antognolli", "antognolli@profusion.mobi", "antognolli"), - Committer("Rafael Brandao", "rafael.lobo@openbossa.org", "rafaelbrandao"), - Committer("Rafael Weinstein", "rafaelw@chromium.org", "rafaelw"), - Committer("Raphael Kubo da Costa", ["rakuco@webkit.org", "rakuco@FreeBSD.org", "raphael.kubo.da.costa@intel.com"], "rakuco"), - Committer("Ravi Kasibhatla", "ravi.kasibhatla@motorola.com", "kphanee"), - Committer("Renata Hodovan", "reni@webkit.org", "reni"), - Committer("Robert Hogan", ["robert@webkit.org", "robert@roberthogan.net", "lists@roberthogan.net"], "mwenge"), - Committer("Robert Kroeger", "rjkroege@chromium.org", "rjkroege"), - Committer("Roger Fong", "roger_fong@apple.com", "rfong"), - Committer("Roland Steiner", "rolandsteiner@chromium.org"), - Committer("Ryuan Choi", "ryuan.choi@samsung.com", "ryuan"), - Committer("Satish Sampath", "satish@chromium.org"), - Committer("Scott Violet", "sky@chromium.org", "sky"), - Committer("Sergio Villar Senin", ["svillar@igalia.com", "sergio@webkit.org"], "svillar"), - Committer("Shawn Singh", "shawnsingh@chromium.org", "shawnsingh"), - Committer("Shinya Kawanaka", "shinyak@chromium.org", "shinyak"), - Committer("Siddharth Mathur", "siddharth.mathur@nokia.com", "simathur"), - Committer("Simon Pena", "spena@igalia.com", "spenap"), - Committer("Stephen Chenney", "schenney@chromium.org", "schenney"), - Committer("Steve Lacey", "sjl@chromium.org", "stevela"), - Committer("Taiju Tsuiki", "tzik@chromium.org", "tzik"), - Committer("Takashi Sakamoto", "tasak@google.com", "tasak"), - Committer("Takashi Toyoshima", "toyoshim@chromium.org", "toyoshim"), - Committer("Terry Anderson", "tdanderson@chromium.org", "tdanderson"), - Committer("Thiago Marcos P. Santos", ["tmpsantos@gmail.com", "thiago.santos@intel.com"], "tmpsantos"), - Committer("Thomas Sepez", "tsepez@chromium.org", "tsepez"), - Committer("Tom Hudson", ["tomhudson@google.com", "tomhudson@chromium.org"], "tomhudson"), - Committer("Tom Zakrajsek", "tomz@codeaurora.org", "tomz"), - Committer("Tommy Widenflycht", "tommyw@google.com", "tommyw"), - Committer("Trey Matteson", "trey@usa.net", "trey"), - Committer("Tristan O'Tierney", ["tristan@otierney.net", "tristan@apple.com"]), - Committer("Vangelis Kokkevis", "vangelis@chromium.org", "vangelis"), - Committer("Viatcheslav Ostapenko", ["ostap73@gmail.com", "v.ostapenko@samsung.com", "v.ostapenko@sisa.samsung.com"], "ostap"), - Committer("Victor Carbune", "victor@rosedu.org", "vcarbune"), - Committer("Victor Wang", "victorw@chromium.org", "victorw"), - Committer("Victoria Kirst", ["vrk@chromium.org", "vrk@google.com"], "vrk"), - Committer("Vincent Scheib", "scheib@chromium.org", "scheib"), - Committer("Vineet Chaudhary", "rgf748@motorola.com", "vineetc"), - Committer("Vitaly Repeshko", "vitalyr@chromium.org"), - Committer("Vivek Galatage", ["vivekg@webkit.org", "vivek.vg@samsung.com"], "vivekg"), - Committer("William Siegrist", "wsiegrist@apple.com", "wms"), - Committer("W. James MacLean", "wjmaclean@chromium.org", "seumas"), - Committer("Xianzhu Wang", ["wangxianzhu@chromium.org", "phnixwxz@gmail.com", "wangxianzhu@google.com"], "wangxianzhu"), - Committer("Xiaomei Ji", "xji@chromium.org", "xji"), - Committer("Yael Aharon", "yael@webkit.org", "yael"), - Committer("Yaar Schnitman", ["yaar@chromium.org", "yaar@google.com"]), - Committer("Yi Shen", ["yi.4.shen@nokia.com", "shenyi2006@gmail.com"]), - Committer("Yongjun Zhang", ["yongjun.zhang@nokia.com", "yongjun_zhang@apple.com"]), - Committer("Yoshifumi Inoue", "yosin@chromium.org", "yosin"), - Committer("Yuqiang Xian", "yuqiang.xian@intel.com"), - Committer("Yuzo Fujishima", "yuzo@google.com", "yuzo"), - Committer("Zalan Bujtas", ["zbujtas@gmail.com", "zalan.bujtas@nokia.com"], "zalan"), - Committer("Zeno Albisser", ["zeno@webkit.org", "zeno.albisser@nokia.com"], "zalbisser"), - Committer("Zhenyao Mo", "zmo@google.com", "zhenyao"), - Committer("Zoltan Horvath", ["zoltan@webkit.org", "hzoltan@inf.u-szeged.hu", "horvath.zoltan.6@stud.u-szeged.hu"], "zoltan"), - Committer(u"\u017dan Dober\u0161ek", "zandobersek@gmail.com", "zdobersek"), -] - - -# This is intended as a canonical, machine-readable list of all reviewers for -# WebKit. If your name is missing here and you are a reviewer, please add it. -# No review needed. - - -reviewers_list = [ - Reviewer("Abhishek Arya", "inferno@chromium.org", "inferno-sec"), - Reviewer("Ada Chan", "adachan@apple.com", "chanada"), - Reviewer("Adam Barth", "abarth@webkit.org", "abarth"), - Reviewer("Adam Roben", ["aroben@webkit.org", "aroben@apple.com"], "aroben"), - Reviewer("Adam Treat", ["treat@kde.org", "treat@webkit.org", "atreat@rim.com"], "manyoso"), - Reviewer("Adele Peterson", "adele@apple.com", "adele"), - Reviewer("Adrienne Walker", ["enne@google.com", "enne@chromium.org"], "enne"), - Reviewer("Alejandro G. Castro", ["alex@igalia.com", "alex@webkit.org"], "alexg__"), - Reviewer("Alexander Pavlov", ["apavlov@chromium.org", "pavlov81@gmail.com"], "apavlov"), - Reviewer("Alexey Proskuryakov", ["ap@webkit.org", "ap@apple.com"], "ap"), - Reviewer("Alexis Menard", ["alexis@webkit.org", "menard@kde.org"], "darktears"), - Reviewer("Alice Liu", "alice.liu@apple.com", "aliu"), - Reviewer("Alp Toker", ["alp@nuanti.com", "alp@atoker.com", "alp@webkit.org"], "alp"), - Reviewer("Anders Carlsson", ["andersca@apple.com", "acarlsson@apple.com"], "andersca"), - Reviewer("Andreas Kling", ["akling@apple.com", "kling@webkit.org", "awesomekling@apple.com", "andreas.kling@nokia.com"], "kling"), - Reviewer("Andy Estes", "aestes@apple.com", "estes"), - Reviewer("Antonio Gomes", ["tonikitoo@webkit.org", "agomes@rim.com"], "tonikitoo"), - Reviewer("Antti Koivisto", ["koivisto@iki.fi", "antti@apple.com", "antti.j.koivisto@nokia.com"], "anttik"), - Reviewer("Ariya Hidayat", ["ariya.hidayat@gmail.com", "ariya@sencha.com", "ariya@webkit.org"], "ariya"), - Reviewer("Benjamin Poulain", ["benjamin@webkit.org", "benjamin.poulain@nokia.com", "ikipou@gmail.com"], "benjaminp"), - Reviewer("Beth Dakin", "bdakin@apple.com", "dethbakin"), - Reviewer("Brady Eidson", "beidson@apple.com", "bradee-oh"), - Reviewer("Brent Fulgham", "bfulgham@webkit.org", "bfulgham"), - Reviewer("Brian Weinstein", "bweinstein@apple.com", "bweinstein"), - Reviewer("Caio Marcelo de Oliveira Filho", ["cmarcelo@webkit.org", "caio.oliveira@openbossa.org"], "cmarcelo"), - Reviewer("Cameron Zwarich", ["zwarich@apple.com", "cwzwarich@apple.com", "cwzwarich@webkit.org"]), - Reviewer("Carlos Garcia Campos", ["cgarcia@igalia.com", "carlosgc@gnome.org", "carlosgc@webkit.org"], "KaL"), - Reviewer("Chang Shu", ["cshu@webkit.org", "c.shu@sisa.samsung.com"], "cshu"), - Reviewer("Chris Blumenberg", "cblu@apple.com", "cblu"), - Reviewer("Chris Marrin", "cmarrin@apple.com", "cmarrin"), - Reviewer("Chris Fleizach", "cfleizach@apple.com", "cfleizach"), - Reviewer("Chris Jerdonek", "cjerdonek@webkit.org", "cjerdonek"), - Reviewer("Chris Rogers", "crogers@google.com", "crogers"), - Reviewer(u"Csaba Osztrogon\u00e1c", "ossy@webkit.org", "ossy"), - Reviewer("Dan Bernstein", ["mitz@webkit.org", "mitz@apple.com"], "mitzpettel"), - Reviewer("Daniel Bates", ["dbates@webkit.org", "dbates@rim.com"], "dydz"), - Reviewer("Darin Adler", "darin@apple.com", "darin"), - Reviewer("Darin Fisher", ["fishd@chromium.org", "darin@chromium.org"], "fishd"), - Reviewer("David Harrison", "harrison@apple.com", "harrison"), - Reviewer("David Hyatt", "hyatt@apple.com", ["dhyatt", "hyatt"]), - Reviewer("David Kilzer", ["ddkilzer@webkit.org", "ddkilzer@apple.com"], "ddkilzer"), - Reviewer("David Levin", "levin@chromium.org", "dave_levin"), - Reviewer("Dean Jackson", "dino@apple.com", "dino"), - Reviewer("Dimitri Glazkov", "dglazkov@chromium.org", "dglazkov"), - Reviewer("Dirk Pranke", "dpranke@chromium.org", "dpranke"), - Reviewer("Dirk Schulze", "krit@webkit.org", "krit"), - Reviewer("Dmitry Titov", "dimich@chromium.org", "dimich"), - Reviewer("Don Melton", "gramps@apple.com", "gramps"), - Reviewer("Dumitru Daniliuc", "dumi@chromium.org", "dumi"), - Reviewer("Emil A Eklund", "eae@chromium.org", "eae"), - Reviewer("Enrica Casucci", "enrica@apple.com", "enrica"), - Reviewer("Eric Carlson", "eric.carlson@apple.com", "eric_carlson"), - Reviewer("Eric Seidel", "eric@webkit.org", "eseidel"), - Reviewer("Filip Pizlo", "fpizlo@apple.com", "pizlo"), - Reviewer("Gavin Barraclough", "barraclough@apple.com", "gbarra"), - Reviewer("Geoffrey Garen", "ggaren@apple.com", "ggaren"), - Reviewer("George Staikos", ["staikos@kde.org", "staikos@webkit.org"]), - Reviewer("Gustavo Noronha Silva", ["gns@gnome.org", "kov@webkit.org", "gustavo.noronha@collabora.co.uk", "gustavo.noronha@collabora.com"], "kov"), - Reviewer("Gyuyoung Kim", ["gyuyoung.kim@samsung.com", "gyuyoung.kim@webkit.org"], "gyuyoung"), - Reviewer("Hajime Morita", ["morrita@google.com", "morrita@chromium.org"], "morrita"), - Reviewer("Holger Freyther", ["zecke@selfish.org", "zecke@webkit.org"], "zecke"), - Reviewer("James Robinson", ["jamesr@chromium.org", "jamesr@google.com"], "jamesr"), - Reviewer("Jan Alonzo", ["jmalonzo@gmail.com", "jmalonzo@webkit.org"], "janm"), - Reviewer("Jeremy Orlow", ["jorlow@webkit.org", "jorlow@chromium.org"], "jorlow"), - Reviewer("Jessie Berlin", ["jberlin@webkit.org", "jberlin@apple.com"], "jessieberlin"), - Reviewer("Jian Li", "jianli@chromium.org", "jianli"), - Reviewer("Jocelyn Turcotte", ["jocelyn.turcotte@digia.com", "jocelyn.turcotte@nokia.com"], "jturcotte"), - Reviewer("Jochen Eisinger", "jochen@chromium.org", "jochen__"), - Reviewer("John Sullivan", "sullivan@apple.com", "sullivan"), - Reviewer("Jon Honeycutt", "jhoneycutt@apple.com", "jhoneycutt"), - Reviewer("Joseph Pecoraro", ["joepeck@webkit.org", "pecoraro@apple.com"], "JoePeck"), - Reviewer("Julien Chaffraix", ["jchaffraix@webkit.org", "julien.chaffraix@gmail.com", "jchaffraix@google.com", "jchaffraix@codeaurora.org"], "jchaffraix"), - Reviewer("Justin Garcia", "justin.garcia@apple.com", "justing"), - Reviewer("Ken Kocienda", "kocienda@apple.com"), - Reviewer("Kenneth Rohde Christiansen", ["kenneth@webkit.org", "kenneth.r.christiansen@intel.com", "kenneth.christiansen@gmail.com"], ["kenneth_", "kenneth", "kenne"]), - Reviewer("Kenneth Russell", ["kbr@google.com", "kbr@chromium.org"], ["kbr_google", "kbrgg"]), - Reviewer("Kent Tamura", ["tkent@chromium.org", "tkent@google.com"], "tkent"), - Reviewer("Kentaro Hara", ["haraken@chromium.org"], "haraken"), - Reviewer("Kevin Decker", "kdecker@apple.com", "superkevin"), - Reviewer("Kevin McCullough", "kmccullough@apple.com", "maculloch"), - Reviewer("Kevin Ollivier", ["kevino@theolliviers.com", "kevino@webkit.org"], "kollivier"), - Reviewer("Lars Knoll", ["lars@trolltech.com", "lars@kde.org", "lars.knoll@nokia.com"], "lars"), - Reviewer("Laszlo Gombos", ["laszlo.gombos@webkit.org", "l.gombos@samsung.com", "laszlo.1.gombos@nokia.com"], "lgombos"), - Reviewer("Levi Weintraub", ["leviw@chromium.org", "leviw@google.com", "lweintraub@apple.com"], "leviw"), - Reviewer("Luiz Agostini", ["luiz@webkit.org", "luiz.agostini@openbossa.org"], "lca"), - Reviewer("Maciej Stachowiak", "mjs@apple.com", "othermaciej"), - Reviewer("Mark Hahnenberg", "mhahnenberg@apple.com", "mhahnenberg"), - Reviewer("Mark Rowe", "mrowe@apple.com", "bdash"), - Reviewer("Martin Robinson", ["mrobinson@webkit.org", "mrobinson@igalia.com", "martin.james.robinson@gmail.com"], "mrobinson"), - Reviewer("Michael Saboff", "msaboff@apple.com", "msaboff"), - Reviewer("Mihai Parparita", "mihaip@chromium.org", "mihaip"), - Reviewer("Nate Chapin", "japhet@chromium.org", ["japhet", "natechapin"]), - Reviewer("Nikolas Zimmermann", ["zimmermann@kde.org", "zimmermann@physik.rwth-aachen.de", "zimmermann@webkit.org", "nzimmermann@rim.com"], "wildfox"), - Reviewer("Noam Rosenthal", ["noam@webkit.org", "noam.rosenthal@nokia.com"], "noamr"), - Reviewer("Ojan Vafai", "ojan@chromium.org", "ojan"), - Reviewer("Oliver Hunt", "oliver@apple.com", "olliej"), - Reviewer("Pavel Feldman", ["pfeldman@chromium.org", "pfeldman@google.com"], "pfeldman"), - Reviewer("Philippe Normand", ["pnormand@igalia.com", "philn@webkit.org", "philn@igalia.com"], ["philn-tp", "pnormand"]), - Reviewer("Richard Williamson", "rjw@apple.com", "rjw"), - Reviewer("Rob Buis", ["rwlbuis@gmail.com", "rwlbuis@webkit.org", "rbuis@rim.com"], "rwlbuis"), - Reviewer("Ryosuke Niwa", "rniwa@webkit.org", "rniwa"), - Reviewer("Sam Weinig", ["sam@webkit.org", "weinig@apple.com"], "weinig"), - Reviewer("Shinichiro Hamaji", "hamaji@chromium.org", "hamaji"), - Reviewer("Simon Fraser", "simon.fraser@apple.com", "smfr"), - Reviewer("Simon Hausmann", ["hausmann@webkit.org", "hausmann@kde.org", "simon.hausmann@digia.com"], "tronical"), - Reviewer("Stephanie Lewis", "slewis@apple.com", "sundiamonde"), - Reviewer("Stephen White", "senorblanco@chromium.org", "senorblanco"), - Reviewer("Steve Block", "steveblock@google.com", "steveblock"), - Reviewer("Steve Falkenburg", "sfalken@apple.com", "sfalken"), - Reviewer("Tim Omernick", "timo@apple.com"), - Reviewer("Timothy Hatcher", ["timothy@apple.com", "timothy@hatcher.name"], "xenon"), - Reviewer("Tim Horton", "timothy_horton@apple.com", "thorton"), - Reviewer("Tony Chang", "tony@chromium.org", "tony^work"), - Reviewer("Tony Gentilcore", "tonyg@chromium.org", "tonyg-cr"), - Reviewer(u"Tor Arne Vestb\u00f8", ["vestbo@webkit.org", "tor.arne.vestbo@nokia.com"], "torarne"), - Reviewer("Vicki Murley", "vicki@apple.com"), - Reviewer("Vsevolod Vlasov", "vsevik@chromium.org", "vsevik"), - Reviewer("Xan Lopez", ["xan.lopez@gmail.com", "xan@gnome.org", "xan@webkit.org", "xlopez@igalia.com"], "xan"), - Reviewer("Yong Li", ["yoli@rim.com", "yong.li.webkit@gmail.com"], "yoli"), - Reviewer("Yury Semikhatsky", "yurys@chromium.org", "yurys"), - Reviewer("Yuta Kitamura", "yutak@chromium.org", "yutak"), - Reviewer("Zack Rusin", "zack@kde.org", "zackr"), - Reviewer("Zoltan Herczeg", ["zherczeg@webkit.org", "zherczeg@inf.u-szeged.hu"], "zherczeg"), -] - class CommitterList(object): # Committers and reviewers are passed in to allow easy testing def __init__(self, - committers=committers_unable_to_review, - reviewers=reviewers_list, - contributors=contributors_who_are_not_committers, - watchers=watchers_who_are_not_contributors): - self._accounts = watchers + contributors + committers + reviewers + committers=[], + reviewers=[], + contributors=[]): + # FIXME: These arguments only exist for testing. Clean it up. + if not (committers or reviewers or contributors): + loaded_data = self.load_json() + contributors = loaded_data['Contributors'] + committers = loaded_data['Committers'] + reviewers = loaded_data['Reviewers'] + self._contributors = contributors + committers + reviewers self._committers = committers + reviewers self._reviewers = reviewers @@ -579,8 +127,18 @@ class CommitterList(object): self._accounts_by_email = {} self._accounts_by_login = {} - def accounts(self): - return self._accounts + @staticmethod + @memoized + def load_json(): + filesystem = FileSystem() + json_path = filesystem.join(filesystem.dirname(filesystem.path_to_module('webkitpy.common.config')), 'contributors.json') + contributors = json.loads(filesystem.read_text_file(json_path)) + + return { + 'Contributors': [Contributor(name, data.get('emails'), data.get('nicks')) for name, data in contributors['Contributors'].iteritems()], + 'Committers': [Committer(name, data.get('emails'), data.get('nicks')) for name, data in contributors['Committers'].iteritems()], + 'Reviewers': [Reviewer(name, data.get('emails'), data.get('nicks')) for name, data in contributors['Reviewers'].iteritems()], + } def contributors(self): return self._contributors @@ -601,7 +159,7 @@ class CommitterList(object): def _email_to_account_map(self): if not len(self._accounts_by_email): - for account in self._accounts: + for account in self._contributors: for email in account.emails: assert(email not in self._accounts_by_email) # We should never have duplicate emails. self._accounts_by_email[email] = account @@ -609,18 +167,13 @@ class CommitterList(object): def _login_to_account_map(self): if not len(self._accounts_by_login): - for account in self._accounts: + for account in self._contributors: if account.emails: login = account.bugzilla_email() assert(login not in self._accounts_by_login) # We should never have duplicate emails. self._accounts_by_login[login] = account return self._accounts_by_login - def _contributor_only(self, record): - if record and not record.is_contributor: - return None - return record - def _committer_only(self, record): if record and not record.can_commit: return None @@ -642,7 +195,8 @@ class CommitterList(object): return None def contributors_by_search_string(self, string): - return filter(lambda contributor: contributor.contains_string(string), self.contributors()) + glob_matches = filter(lambda contributor: contributor.matches_glob(string), self.contributors()) + return glob_matches or filter(lambda contributor: contributor.contains_string(string), self.contributors()) def contributors_by_email_username(self, string): string = string + '@' @@ -673,7 +227,7 @@ class CommitterList(object): string_in_lowercase = string.lower() # 1. Exact match for fullname, email and irc_nicknames - account = self.contributor_by_name(string_in_lowercase) or self.account_by_email(string_in_lowercase) or self.contributor_by_irc_nickname(string_in_lowercase) + account = self.contributor_by_name(string_in_lowercase) or self.contributor_by_email(string_in_lowercase) or self.contributor_by_irc_nickname(string_in_lowercase) if account: return [account], 0 @@ -706,20 +260,14 @@ class CommitterList(object): return [], len(string) return contributorWithMinDistance, minDistance - def account_by_login(self, login): - return self._login_to_account_map().get(login.lower()) if login else None - - def account_by_email(self, email): + def contributor_by_email(self, email): return self._email_to_account_map().get(email.lower()) if email else None def contributor_by_name(self, name): return self._name_to_contributor_map().get(name.lower()) if name else None - def contributor_by_email(self, email): - return self._contributor_only(self.account_by_email(email)) - def committer_by_email(self, email): - return self._committer_only(self.account_by_email(email)) + return self._committer_only(self.contributor_by_email(email)) def reviewer_by_email(self, email): - return self._reviewer_only(self.account_by_email(email)) + return self._reviewer_only(self.contributor_by_email(email)) |