diff options
Diffstat (limited to 'Tools/Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py')
-rw-r--r-- | Tools/Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/Tools/Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py b/Tools/Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py index c3b723ed1..50ecc4646 100644 --- a/Tools/Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py +++ b/Tools/Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py @@ -26,7 +26,7 @@ # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -import unittest +import unittest2 as unittest from webkitpy.common.system.outputcapture import OutputCapture from webkitpy.thirdparty.mock import Mock @@ -38,7 +38,6 @@ class ValidateChangeLogsTest(unittest.TestCase): def _assert_start_line_produces_output(self, start_line, should_fail=False, non_interactive=False): tool = MockTool() - tool._checkout.is_path_to_changelog = lambda path: True step = ValidateChangeLogs(tool, MockOptions(git_commit=None, non_interactive=non_interactive)) diff_file = Mock() diff_file.filename = "mock/ChangeLog" @@ -56,3 +55,15 @@ class ValidateChangeLogsTest(unittest.TestCase): self._assert_start_line_produces_output(1, non_interactive=False) self._assert_start_line_produces_output(8, non_interactive=True, should_fail=True) + + def test_changelog_contains_oops(self): + tool = MockTool() + tool._checkout.is_path_to_changelog = lambda path: True + step = ValidateChangeLogs(tool, MockOptions(git_commit=None, non_interactive=True, check_oops=True)) + diff_file = Mock() + diff_file.filename = "mock/ChangeLog" + diff_file.lines = [(1, 1, "foo"), (2, 2, "bar OOPS! bar"), (3, 3, "foo")] + self.assertTrue(OutputCapture().assert_outputs(self, step._changelog_contains_oops, [diff_file], expected_logs='')) + + diff_file.lines = [(1, 1, "foo"), (2, 2, "bar OOPS bar"), (3, 3, "foo")] + self.assertFalse(OutputCapture().assert_outputs(self, step._changelog_contains_oops, [diff_file], expected_logs='')) |