diff options
Diffstat (limited to 'Tools/Scripts')
6 files changed, 17 insertions, 24 deletions
diff --git a/Tools/Scripts/webkitpy/common/config/committers.py b/Tools/Scripts/webkitpy/common/config/committers.py index 1b170847b..bfdc30e9d 100644 --- a/Tools/Scripts/webkitpy/common/config/committers.py +++ b/Tools/Scripts/webkitpy/common/config/committers.py @@ -260,7 +260,6 @@ committers_unable_to_review = [ Committer("Graham Dennis", ["Graham.Dennis@gmail.com", "gdennis@webkit.org"]), Committer("Greg Bolsinga", "bolsinga@apple.com"), Committer("Grzegorz Czajkowski", "g.czajkowski@samsung.com", "grzegorz"), - Committer("Gyuyoung Kim", ["gyuyoung.kim@samsung.com", "gyuyoung.kim@webkit.org"], "gyuyoung"), Committer("Hans Wennborg", "hans@chromium.org", "hwennborg"), Committer("Hayato Ito", "hayato@chromium.org", "hayato"), Committer("Hironori Bono", "hbono@chromium.org", "hbono"), @@ -471,6 +470,7 @@ reviewers_list = [ Reviewer("Geoffrey Garen", "ggaren@apple.com", "ggaren"), Reviewer("George Staikos", ["staikos@kde.org", "staikos@webkit.org"]), Reviewer("Gustavo Noronha Silva", ["gns@gnome.org", "kov@webkit.org", "gustavo.noronha@collabora.co.uk", "gustavo.noronha@collabora.com"], "kov"), + Reviewer("Gyuyoung Kim", ["gyuyoung.kim@samsung.com", "gyuyoung.kim@webkit.org"], "gyuyoung"), Reviewer("Hajime Morita", ["morrita@google.com", "morrita@chromium.org"], "morrita"), Reviewer("Holger Freyther", ["zecke@selfish.org", "zecke@webkit.org"], "zecke"), Reviewer("James Robinson", ["jamesr@chromium.org", "jamesr@google.com"], "jamesr"), diff --git a/Tools/Scripts/webkitpy/common/config/watchlist b/Tools/Scripts/webkitpy/common/config/watchlist index 513403bc7..13c912ff9 100755 --- a/Tools/Scripts/webkitpy/common/config/watchlist +++ b/Tools/Scripts/webkitpy/common/config/watchlist @@ -229,8 +229,8 @@ "ChromiumPublicApi": [ "abarth@webkit.org", "dglazkov@chromium.org", "fishd@chromium.org", "jamesr@chromium.org", "tkent+wkapi@chromium.org" ], "DOMAttributes": [ "cmarcelo@webkit.org", ], "EFL": [ "rakuco@webkit.org", "gyuyoung.kim@samsung.com" ], - "EFLWebKit2PlatformSpecific": [ "gyuyoung.kim@samsung.com" ], - "EFLWebKit2PublicAPI": [ "gyuyoung.kim@samsung.com" ], + "EFLWebKit2PlatformSpecific": [ "gyuyoung.kim@samsung.com", "rakuco@webkit.org" ], + "EFLWebKit2PublicAPI": [ "gyuyoung.kim@samsung.com", "rakuco@webkit.org" ], "Editing": [ "mifenton@rim.com" ], "Forms": [ "tkent@chromium.org", "mifenton@rim.com" ], "FrameLoader": [ "abarth@webkit.org", "japhet@chromium.org" ], diff --git a/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py b/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py index 25dd44f40..f46cd34e5 100644 --- a/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py +++ b/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py @@ -57,18 +57,7 @@ class LeakDetector(object): "Flash_EnforceLocalSecurity", # leaks in Flash plug-in code, rdar://problem/4449747 "ScanFromString", # <http://code.google.com/p/angleproject/issues/detail?id=249> leak in ANGLE ] - if self._port.is_leopard(): - callstacks += [ - "CFHTTPMessageAppendBytes", # leak in CFNetwork, rdar://problem/5435912 - "sendDidReceiveDataCallback", # leak in CFNetwork, rdar://problem/5441619 - "_CFHTTPReadStreamReadMark", # leak in CFNetwork, rdar://problem/5441468 - "httpProtocolStart", # leak in CFNetwork, rdar://problem/5468837 - "_CFURLConnectionSendCallbacks", # leak in CFNetwork, rdar://problem/5441600 - "DispatchQTMsg", # leak in QuickTime, PPC only, rdar://problem/5667132 - "QTMovieContentView createVisualContext", # leak in QuickTime, PPC only, rdar://problem/5667132 - "_CopyArchitecturesForJVMVersion", # leak in Java, rdar://problem/5910823 - ] - elif self._port.is_snowleopard(): + if self._port.is_snowleopard(): callstacks += [ "readMakerNoteProps", # <rdar://problem/7156432> leak in ImageIO "QTKitMovieControllerView completeUISetup", # <rdar://problem/7155156> leak in QTKit diff --git a/Tools/Scripts/webkitpy/layout_tests/port/mac.py b/Tools/Scripts/webkitpy/layout_tests/port/mac.py index deee3d1be..400959cfd 100644 --- a/Tools/Scripts/webkitpy/layout_tests/port/mac.py +++ b/Tools/Scripts/webkitpy/layout_tests/port/mac.py @@ -98,6 +98,14 @@ class MacPort(ApplePort): def operating_system(self): return 'mac' + # Belongs on a Platform object. + def is_snowleopard(self): + return self._version == "snowleopard" + + # Belongs on a Platform object. + def is_lion(self): + return self._version == "lion" + def default_child_processes(self): # FIXME: The Printer isn't initialized when this is called, so using _log would just show an unitialized logger error. diff --git a/Tools/Scripts/webkitpy/performance_tests/perftest.py b/Tools/Scripts/webkitpy/performance_tests/perftest.py index 8ef945893..69d9363f4 100644 --- a/Tools/Scripts/webkitpy/performance_tests/perftest.py +++ b/Tools/Scripts/webkitpy/performance_tests/perftest.py @@ -319,9 +319,7 @@ class ReplayPerfTest(PageLoadingPerfTest): _log.error("Web page replay didn't start.") return None - super(ReplayPerfTest, self).run_single(driver, "about:blank", time_out_ms) - _log.debug("Loading the page") - + _log.debug("Web page replay started. Loading the page.") output = super(ReplayPerfTest, self).run_single(driver, self._url, time_out_ms, should_run_pixel_test=True) if self.run_failed(output): return None diff --git a/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py b/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py index 3b7c609ce..2b35e71ee 100755 --- a/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py +++ b/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py @@ -192,9 +192,8 @@ class TestReplayPerfTest(unittest.TestCase): finally: actual_stdout, actual_stderr, actual_logs = output_capture.restore_output() - self.assertEqual(len(loaded_pages), 2) - self.assertEqual(loaded_pages[0].test_name, 'about:blank') - self.assertEqual(loaded_pages[1].test_name, 'http://some-test/') + self.assertEqual(len(loaded_pages), 1) + self.assertEqual(loaded_pages[0].test_name, 'http://some-test/') self.assertEqual(actual_stdout, '') self.assertEqual(actual_stderr, '') self.assertEqual(actual_logs, '') @@ -259,9 +258,8 @@ class TestReplayPerfTest(unittest.TestCase): finally: actual_stdout, actual_stderr, actual_logs = output_capture.restore_output() - self.assertEqual(len(loaded_pages), 2) - self.assertEqual(loaded_pages[0].test_name, 'about:blank') - self.assertEqual(loaded_pages[1].test_name, 'http://some-test/') + self.assertEqual(len(loaded_pages), 1) + self.assertEqual(loaded_pages[0].test_name, 'http://some-test/') self.assertEqual(actual_stdout, '') self.assertEqual(actual_stderr, '') self.assertEqual(actual_logs, 'error: some-test.replay\nsome error\n') |