1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
|
/*
* Copyright (C) 2015-2016 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
* EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
* EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
* PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
* PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
* OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "config.h"
#include "B3MoveConstants.h"
#if ENABLE(B3_JIT)
#include "B3BasicBlockInlines.h"
#include "B3Dominators.h"
#include "B3InsertionSetInlines.h"
#include "B3MemoryValue.h"
#include "B3PhaseScope.h"
#include "B3ProcedureInlines.h"
#include "B3ValueInlines.h"
#include "B3ValueKeyInlines.h"
#include <wtf/HashMap.h>
#include <wtf/Vector.h>
namespace JSC { namespace B3 {
namespace {
class MoveConstants {
public:
MoveConstants(Procedure& proc)
: m_proc(proc)
, m_insertionSet(proc)
{
}
void run()
{
hoistConstants(
[&] (const ValueKey& key) -> bool {
return key.opcode() == ConstFloat || key.opcode() == ConstDouble;
});
lowerFPConstants();
hoistConstants(
[&] (const ValueKey& key) -> bool {
return key.opcode() == Const32 || key.opcode() == Const64;
});
}
private:
template<typename Filter>
void hoistConstants(const Filter& filter)
{
Dominators& dominators = m_proc.dominators();
HashMap<ValueKey, Value*> valueForConstant;
IndexMap<BasicBlock, Vector<Value*>> materializations(m_proc.size());
// We determine where things get materialized based on where they are used.
for (BasicBlock* block : m_proc) {
for (Value* value : *block) {
for (Value*& child : value->children()) {
ValueKey key = child->key();
if (!filter(key))
continue;
auto result = valueForConstant.add(key, child);
if (result.isNewEntry) {
// Assume that this block is where we want to materialize the value.
child->owner = block;
continue;
}
// Make 'value' use the canonical constant rather than the one it was using.
child = result.iterator->value;
// Determine the least common dominator. That's the lowest place in the CFG where
// we could materialize the constant while still having only one materialization
// in the resulting code.
while (!dominators.dominates(child->owner, block))
child->owner = dominators.idom(child->owner);
}
}
}
// Make sure that each basic block knows what to materialize. This also refines the
// materialization block based on execution frequency. It finds the minimum block frequency
// of all of its dominators, and selects the closest block amongst those that are tied for
// lowest frequency.
for (auto& entry : valueForConstant) {
Value* value = entry.value;
for (BasicBlock* block = value->owner; block; block = dominators.idom(block)) {
if (block->frequency() < value->owner->frequency())
value->owner = block;
}
materializations[value->owner].append(value);
}
// Get rid of Value's that are fast constants but aren't canonical. Also remove the canonical
// ones from the CFG, since we're going to reinsert them elsewhere.
for (BasicBlock* block : m_proc) {
for (Value*& value : *block) {
ValueKey key = value->key();
if (!filter(key))
continue;
if (valueForConstant.get(key) == value)
value = m_proc.add<Value>(Nop, value->origin());
else
value->replaceWithNop();
}
}
// Now make sure that we move constants to where they are supposed to go. Again, we do this
// based on uses.
for (BasicBlock* block : m_proc) {
for (unsigned valueIndex = 0; valueIndex < block->size(); ++valueIndex) {
Value* value = block->at(valueIndex);
for (Value* child : value->children()) {
ValueKey key = child->key();
if (!filter(key))
continue;
// If we encounter a fast constant, then it must be canonical, since we already
// got rid of the non-canonical ones.
ASSERT(valueForConstant.get(key) == child);
if (child->owner != block) {
// This constant isn't our problem. It's going to be materialized in another
// block.
continue;
}
// We're supposed to materialize this constant in this block, and we haven't
// done it yet.
m_insertionSet.insertValue(valueIndex, child);
child->owner = nullptr;
}
}
// We may have some constants that need to be materialized right at the end of this
// block.
for (Value* value : materializations[block]) {
if (!value->owner) {
// It's already materialized in this block.
continue;
}
m_insertionSet.insertValue(block->size() - 1, value);
}
m_insertionSet.execute(block);
}
}
void lowerFPConstants()
{
for (Value* value : m_proc.values()) {
ValueKey key = value->key();
if (goesInTable(key))
m_constTable.add(key, m_constTable.size());
}
m_dataSection = static_cast<int64_t*>(m_proc.addDataSection(m_constTable.size() * sizeof(int64_t)));
for (auto& entry : m_constTable)
m_dataSection[entry.value] = entry.key.value();
IndexSet<Value> offLimits;
for (BasicBlock* block : m_proc) {
for (unsigned valueIndex = 0; valueIndex < block->size(); ++valueIndex) {
StackmapValue* value = block->at(valueIndex)->as<StackmapValue>();
if (!value)
continue;
for (unsigned childIndex = 0; childIndex < value->numChildren(); ++childIndex) {
if (!value->constrainedChild(childIndex).rep().isAny())
continue;
Value*& child = value->child(childIndex);
ValueKey key = child->key();
if (!goesInTable(key))
continue;
child = m_insertionSet.insertValue(
valueIndex, key.materialize(m_proc, value->origin()));
offLimits.add(child);
}
}
m_insertionSet.execute(block);
}
for (BasicBlock* block : m_proc) {
for (unsigned valueIndex = 0; valueIndex < block->size(); ++valueIndex) {
Value* value = block->at(valueIndex);
ValueKey key = value->key();
if (!goesInTable(key))
continue;
if (offLimits.contains(value))
continue;
Value* tableBase = m_insertionSet.insertIntConstant(
valueIndex, value->origin(), pointerType(),
bitwise_cast<intptr_t>(m_dataSection));
Value* result = m_insertionSet.insert<MemoryValue>(
valueIndex, Load, value->type(), value->origin(), tableBase,
sizeof(int64_t) * m_constTable.get(key));
value->replaceWithIdentity(result);
}
m_insertionSet.execute(block);
}
}
bool goesInTable(const ValueKey& key)
{
return (key.opcode() == ConstDouble && key != doubleZero())
|| (key.opcode() == ConstFloat && key != floatZero());
}
static ValueKey doubleZero()
{
return ValueKey(ConstDouble, Double, 0.0);
}
static ValueKey floatZero()
{
return ValueKey(ConstFloat, Double, 0.0);
}
Procedure& m_proc;
Vector<Value*> m_toRemove;
HashMap<ValueKey, unsigned> m_constTable;
int64_t* m_dataSection;
HashMap<ValueKey, Value*> m_constants;
InsertionSet m_insertionSet;
};
} // anonymous namespace
void moveConstants(Procedure& proc)
{
PhaseScope phaseScope(proc, "moveConstants");
MoveConstants moveConstants(proc);
moveConstants.run();
}
} } // namespace JSC::B3
#endif // ENABLE(B3_JIT)
|