diff options
author | Michal Kuratczyk <mkuratczyk@pivotal.io> | 2021-03-01 14:06:02 +0100 |
---|---|---|
committer | Michal Kuratczyk <mkuratczyk@pivotal.io> | 2021-03-01 14:06:02 +0100 |
commit | 39e14634529acdd04bcf6ae8c135ab48efca7e27 (patch) | |
tree | 61eca853a5667a1eade732ba379e351747b6d034 | |
parent | d7304aa03949b7647d43229e087e9aa4190ab2a5 (diff) | |
download | rabbitmq-server-git-dirty-io-warnings.tar.gz |
Replace Async threads warning with Dirty I/Odirty-io-warnings
Async threads are basically not used these days.
Dirty I/O schedulers, on the other hand, are used a lot.
-rw-r--r-- | deps/rabbit/src/rabbit.erl | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/deps/rabbit/src/rabbit.erl b/deps/rabbit/src/rabbit.erl index 3da4119d9d..46d22c5c53 100644 --- a/deps/rabbit/src/rabbit.erl +++ b/deps/rabbit/src/rabbit.erl @@ -271,7 +271,7 @@ -define(APPS, [os_mon, mnesia, rabbit_common, rabbitmq_prelaunch, ra, sysmon_handler, rabbit, osiris]). --define(ASYNC_THREADS_WARNING_THRESHOLD, 8). +-define(DIRTY_IO_SCHEDULERS_WARNING_THRESHOLD, 10). %% 1 minute -define(BOOT_START_TIMEOUT, 1 * 60 * 1000). @@ -1230,11 +1230,11 @@ warn_if_kernel_config_dubious() -> "and CPU utilization may worsen.~n") end end, - AsyncThreads = erlang:system_info(thread_pool_size), - case AsyncThreads < ?ASYNC_THREADS_WARNING_THRESHOLD of + DirtyIOSchedulers = erlang:system_info(dirty_io_schedulers), + case DirtyIOSchedulers < ?DIRTY_IO_SCHEDULERS_WARNING_THRESHOLD of true -> rabbit_log:warning( - "Erlang VM is running with ~b I/O threads, " - "file I/O performance may worsen~n", [AsyncThreads]); + "Erlang VM is running with ~b dirty I/O schedulers, " + "file I/O performance may worsen~n", [DirtyIOSchedulers]); false -> ok end, IDCOpts = case application:get_env(kernel, inet_default_connect_options) of |