summaryrefslogtreecommitdiff
path: root/print-openflow.c
diff options
context:
space:
mode:
authorFrancois-Xavier Le Bail <devel.fx.lebail@orange.fr>2020-08-10 16:22:37 +0200
committerFrancois-Xavier Le Bail <devel.fx.lebail@orange.fr>2020-09-05 14:59:21 +0200
commit929e4be621ebdcede37865a5767a175f083f9138 (patch)
treebf6ecbc038696e66176b2d50e04e015767f23b3d /print-openflow.c
parent54b5db3dde658894be730b15480f9b6e27b717a0 (diff)
downloadtcpdump-test-rc.tar.gz
Remove many (761) redundant ND_TCHECK_n() callstest-rc
ND_TCHECK_n(e), n in { 1, 2, 3, 4, 8 }. They are redundant because they are followed by a GET_.*_n(e) call, same n, same e, which do the bounds check. Remove unused 'trunc' labels and most associated codes. Update the outputs of some tests accordingly.
Diffstat (limited to 'print-openflow.c')
-rw-r--r--print-openflow.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/print-openflow.c b/print-openflow.c
index 63666336..894306d1 100644
--- a/print-openflow.c
+++ b/print-openflow.c
@@ -84,19 +84,15 @@ of_header_body_print(netdissect_options *ndo, const u_char *cp, const u_char *ep
if (ep < cp + OF_HEADER_LEN)
goto invalid;
/* version */
- ND_TCHECK_1(cp);
version = GET_U_1(cp);
cp += 1;
/* type */
- ND_TCHECK_1(cp);
type = GET_U_1(cp);
cp += 1;
/* length */
- ND_TCHECK_2(cp);
length = GET_BE_U_2(cp);
cp += 2;
/* xid */
- ND_TCHECK_4(cp);
xid = GET_BE_U_4(cp);
cp += 4;
/* Message length includes the header length and a message always includes