summaryrefslogtreecommitdiff
path: root/print-otv.c
diff options
context:
space:
mode:
authorFrancois-Xavier Le Bail <devel.fx.lebail@orange.fr>2020-08-10 16:22:37 +0200
committerFrancois-Xavier Le Bail <devel.fx.lebail@orange.fr>2020-09-05 14:59:21 +0200
commit929e4be621ebdcede37865a5767a175f083f9138 (patch)
treebf6ecbc038696e66176b2d50e04e015767f23b3d /print-otv.c
parent54b5db3dde658894be730b15480f9b6e27b717a0 (diff)
downloadtcpdump-test-rc.tar.gz
Remove many (761) redundant ND_TCHECK_n() callstest-rc
ND_TCHECK_n(e), n in { 1, 2, 3, 4, 8 }. They are redundant because they are followed by a GET_.*_n(e) call, same n, same e, which do the bounds check. Remove unused 'trunc' labels and most associated codes. Update the outputs of some tests accordingly.
Diffstat (limited to 'print-otv.c')
-rw-r--r--print-otv.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/print-otv.c b/print-otv.c
index dbcef9f6..75e65066 100644
--- a/print-otv.c
+++ b/print-otv.c
@@ -50,16 +50,13 @@ otv_print(netdissect_options *ndo, const u_char *bp, u_int len)
if (len < OTV_HDR_LEN)
goto trunc;
- ND_TCHECK_1(bp);
flags = GET_U_1(bp);
ND_PRINT("flags [%s] (0x%02x), ", flags & 0x08 ? "I" : ".", flags);
bp += 1;
- ND_TCHECK_3(bp);
ND_PRINT("overlay %u, ", GET_BE_U_3(bp));
bp += 3;
- ND_TCHECK_3(bp);
ND_PRINT("instance %u\n", GET_BE_U_3(bp));
bp += 3;