summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZuul <zuul@review.openstack.org>2017-12-02 01:35:38 +0000
committerGerrit Code Review <review@openstack.org>2017-12-02 01:35:39 +0000
commit5cf11908790e7c1f664ea6b87cd69a640b632bda (patch)
tree94e79198c733fd8fee222fd154a951f09b889f59
parent8b32b53a0f9ab7aff351702ba65425a314045800 (diff)
parentdab49df461d7ca68001632f11dc5bf1229271de9 (diff)
downloadpython-openstackclient-5cf11908790e7c1f664ea6b87cd69a640b632bda.tar.gz
Merge "openstack subnet create fails when tags is None"
-rw-r--r--openstackclient/network/v2/_tag.py4
-rw-r--r--releasenotes/notes/bug-1735836-9be6d777a6e6410b.yaml6
2 files changed, 8 insertions, 2 deletions
diff --git a/openstackclient/network/v2/_tag.py b/openstackclient/network/v2/_tag.py
index d1e59937..ce39f35e 100644
--- a/openstackclient/network/v2/_tag.py
+++ b/openstackclient/network/v2/_tag.py
@@ -102,10 +102,10 @@ def update_tags_for_set(client, obj, parsed_args):
if parsed_args.no_tag:
tags = set()
else:
- tags = set(obj.tags)
+ tags = set(obj.tags or [])
if parsed_args.tags:
tags |= set(parsed_args.tags)
- if set(obj.tags) != tags:
+ if set(obj.tags or []) != tags:
client.set_tags(obj, list(tags))
diff --git a/releasenotes/notes/bug-1735836-9be6d777a6e6410b.yaml b/releasenotes/notes/bug-1735836-9be6d777a6e6410b.yaml
new file mode 100644
index 00000000..34604853
--- /dev/null
+++ b/releasenotes/notes/bug-1735836-9be6d777a6e6410b.yaml
@@ -0,0 +1,6 @@
+---
+fixes:
+ - |
+ ``openstack subnet create`` failed with a NoneType exception when
+ there were no tags.
+ [Bug `1735836 <https://bugs.launchpad.net/python-openstackclient/+bug/1735836>`_]