diff options
| author | Jenkins <jenkins@review.openstack.org> | 2017-09-27 05:49:50 +0000 |
|---|---|---|
| committer | Gerrit Code Review <review@openstack.org> | 2017-09-27 05:49:50 +0000 |
| commit | a452c9d82566db6c09419ce2e5c855d51e2631e1 (patch) | |
| tree | 8d960140cf20562a31a10047a2ab2013e49f3f96 /openstackclient/network | |
| parent | 2476a995cf7a228890b6182ca8e29e3cd1fc6def (diff) | |
| parent | 221b7052abcefa56213a6516cecc6de9c73026d1 (diff) | |
| download | python-openstackclient-a452c9d82566db6c09419ce2e5c855d51e2631e1.tar.gz | |
Merge "Support icmp-type and icmp-code to be set as zero"
Diffstat (limited to 'openstackclient/network')
| -rw-r--r-- | openstackclient/network/v2/security_group_rule.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/openstackclient/network/v2/security_group_rule.py b/openstackclient/network/v2/security_group_rule.py index ad685cf8..06d46725 100644 --- a/openstackclient/network/v2/security_group_rule.py +++ b/openstackclient/network/v2/security_group_rule.py @@ -294,9 +294,9 @@ class CreateSecurityGroupRule(common.NetworkAndComputeShowOne): if parsed_args.dst_port and not is_icmp_protocol: attrs['port_range_min'] = parsed_args.dst_port[0] attrs['port_range_max'] = parsed_args.dst_port[1] - if parsed_args.icmp_type: + if parsed_args.icmp_type is not None and parsed_args.icmp_type >= 0: attrs['port_range_min'] = parsed_args.icmp_type - if parsed_args.icmp_code: + if parsed_args.icmp_code is not None and parsed_args.icmp_code >= 0: attrs['port_range_max'] = parsed_args.icmp_code # NOTE(dtroyer): --src-ip and --src-group were deprecated in Nov 2016. |