diff options
| author | Michael McCune <msm@redhat.com> | 2016-04-28 15:15:57 -0400 |
|---|---|---|
| committer | Michael McCune <msm@redhat.com> | 2016-05-02 15:11:45 -0400 |
| commit | b33ee3daf6eebc74fb176b1f2d8018e0e2214377 (patch) | |
| tree | cc2d8caac62370b2e2d16efdf4d2fee2aac131fd /openstackclient/network | |
| parent | 9d7ccd9385776c8c0edf90094b8ef323ef1890a6 (diff) | |
| download | python-openstackclient-b33ee3daf6eebc74fb176b1f2d8018e0e2214377.tar.gz | |
remove assert in favor an if/else
the assert usage in the NonNegativeAction has the potential to allow
unexpected behavior when the python is byte-compiled with optimization
turned on.
Changes
* remove assert in favor of if/else in NonNegativeAction class
* add type specifier to parser arguments for non-negative actions
* correct tests for new int based values
Change-Id: I093e7440b8beff4f179e2c4ed81daff82704c40e
Closes-Bug: #1576375
Diffstat (limited to 'openstackclient/network')
| -rw-r--r-- | openstackclient/network/v2/subnet_pool.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/openstackclient/network/v2/subnet_pool.py b/openstackclient/network/v2/subnet_pool.py index 435db2e1..f1174dda 100644 --- a/openstackclient/network/v2/subnet_pool.py +++ b/openstackclient/network/v2/subnet_pool.py @@ -91,6 +91,7 @@ def _add_prefix_options(parser, for_create=False): parser.add_argument( '--default-prefix-length', metavar='<default-prefix-length>', + type=int, action=parseractions.NonNegativeAction, help=_("Set subnet pool default prefix length") ) @@ -98,11 +99,13 @@ def _add_prefix_options(parser, for_create=False): '--min-prefix-length', metavar='<min-prefix-length>', action=parseractions.NonNegativeAction, + type=int, help=_("Set subnet pool minimum prefix length") ) parser.add_argument( '--max-prefix-length', metavar='<max-prefix-length>', + type=int, action=parseractions.NonNegativeAction, help=_("Set subnet pool maximum prefix length") ) |