summaryrefslogtreecommitdiff
path: root/openstackclient/network
diff options
context:
space:
mode:
authorJenkins <jenkins@review.openstack.org>2016-11-10 18:09:00 +0000
committerGerrit Code Review <review@openstack.org>2016-11-10 18:09:00 +0000
commitf3d3813522cca9b9d43ec9fff0d9ce4f4f546042 (patch)
tree022384c07bca556be528cead878571cc5ed1d5a6 /openstackclient/network
parentc89d441008aa59d0d2809970e49ea56bc1989e46 (diff)
parent57d5f945402681e5f7d62b9ca99fc229927cc784 (diff)
downloadpython-openstackclient-f3d3813522cca9b9d43ec9fff0d9ce4f4f546042.tar.gz
Merge "Allow input the QoS policy name in network rbac create command"
Diffstat (limited to 'openstackclient/network')
-rw-r--r--openstackclient/network/v2/network_rbac.py9
1 files changed, 4 insertions, 5 deletions
diff --git a/openstackclient/network/v2/network_rbac.py b/openstackclient/network/v2/network_rbac.py
index bb29579f..b1e0413f 100644
--- a/openstackclient/network/v2/network_rbac.py
+++ b/openstackclient/network/v2/network_rbac.py
@@ -47,9 +47,9 @@ def _get_attrs(client_manager, parsed_args):
object_id = network_client.find_network(
parsed_args.rbac_object, ignore_missing=False).id
if parsed_args.type == 'qos_policy':
- # TODO(Huanxuan Ao): Support finding a object ID by obejct name
- # after qos policy finding supported in SDK.
- object_id = parsed_args.rbac_object
+ object_id = network_client.find_qos_policy(
+ parsed_args.rbac_object,
+ ignore_missing=False).id
attrs['object_id'] = object_id
identity_client = client_manager.identity
@@ -78,8 +78,7 @@ class CreateNetworkRBAC(command.ShowOne):
parser.add_argument(
'rbac_object',
metavar="<rbac-object>",
- help=_("The object to which this RBAC policy affects (name or "
- "ID for network objects, ID only for QoS policy objects)")
+ help=_("The object to which this RBAC policy affects (name or ID)")
)
parser.add_argument(
'--type',