summaryrefslogtreecommitdiff
path: root/kafka/partitioner/base.py
diff options
context:
space:
mode:
authorDana Powers <dana.powers@rd.io>2015-02-06 11:57:49 -0800
committerDana Powers <dana.powers@rd.io>2015-02-09 10:34:19 -0800
commitfb03c69544221a25e925b8c6af45e44ac6944b2a (patch)
tree3a4f99544c58863cd7ded04c88d4344179e75745 /kafka/partitioner/base.py
parentbb731eb89cc58c2e6799ff2223c47011594986f1 (diff)
downloadkafka-python-fb03c69544221a25e925b8c6af45e44ac6944b2a.tar.gz
make partitions arg optional in *Partitioner.partition, defaulting to self.partitions from init
Diffstat (limited to 'kafka/partitioner/base.py')
-rw-r--r--kafka/partitioner/base.py7
1 files changed, 3 insertions, 4 deletions
diff --git a/kafka/partitioner/base.py b/kafka/partitioner/base.py
index 0b1bb59..857f634 100644
--- a/kafka/partitioner/base.py
+++ b/kafka/partitioner/base.py
@@ -12,14 +12,13 @@ class Partitioner(object):
"""
self.partitions = partitions
- def partition(self, key, partitions):
+ def partition(self, key, partitions=None):
"""
Takes a string key and num_partitions as argument and returns
a partition to be used for the message
Arguments:
- partitions: The list of partitions is passed in every call. This
- may look like an overhead, but it will be useful
- (in future) when we handle cases like rebalancing
+ key: the key to use for partitioning
+ partitions: (optional) a list of partitions.
"""
raise NotImplementedError('partition function has to be implemented')