diff options
| author | hjk <hjk@qt.io> | 2023-02-09 07:23:39 +0100 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2023-02-10 10:23:33 +0000 |
| commit | 4b9aaf6ca11a73d083484cbfa33fcd8a7b25d274 (patch) | |
| tree | d948628e34e6ae1f2e35090853580661796e8545 /src/plugins/coreplugin/plugininstallwizard.cpp | |
| parent | 2a2f6afb040d1bc6ac2197b20414839d1a5ff582 (diff) | |
| download | qt-creator-4b9aaf6ca11a73d083484cbfa33fcd8a7b25d274.tar.gz | |
ExtensionSystem: Remove the IPlugin back pointer to pluginspec
The price of having to loop in two places seems small compared
to cleaner relations between the classes.
There's a new hack in the helpmanager to make sure we aren't
looping to often. The hack wouldn't be needed if the (odd(?))
check there weren't there.
Change-Id: Ifed50213b2de8feedfb45c185808d163c00c19ca
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Diffstat (limited to 'src/plugins/coreplugin/plugininstallwizard.cpp')
| -rw-r--r-- | src/plugins/coreplugin/plugininstallwizard.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/plugins/coreplugin/plugininstallwizard.cpp b/src/plugins/coreplugin/plugininstallwizard.cpp index ae62d21564..6547c78835 100644 --- a/src/plugins/coreplugin/plugininstallwizard.cpp +++ b/src/plugins/coreplugin/plugininstallwizard.cpp @@ -7,6 +7,7 @@ #include "coreplugintr.h" #include "icore.h" +#include <extensionsystem/pluginmanager.h> #include <extensionsystem/pluginspec.h> #include <utils/archive.h> @@ -251,7 +252,7 @@ public: { QTC_ASSERT(m_tempDir.get(), return ); - PluginSpec *coreplugin = CorePlugin::instance()->pluginSpec(); + PluginSpec *coreplugin = PluginManager::specForPlugin(CorePlugin::instance()); // look for plugin QDirIterator it(m_tempDir->path().path(), |